Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152243003: Rename WebNodeCollection to WebElementCollection for clarity (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
tkent, adamk
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename WebNodeCollection to WebElementCollection for clarity Rename WebNodeCollection to WebElementCollection for clarity. WebElementCollection is a wrapper around HTMLCollection which is a collection of Elements, not mere Nodes. The WebElementCollection methods have already been updated to return WebElements instead of WebNodes in r166411. WebNodeCollection is kept for now as a typedef to WebElementCollection until the users on Chromium side are updated. R=tkent, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -170 lines) Patch
M Source/web/WebDocument.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/web/WebElementCollection.cpp View 6 chunks +10 lines, -9 lines 0 comments Download
M Source/web/WebInputElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebNode.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
D Source/web/WebNodeCollection.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
M Source/web/WebNodeList.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/web.gypi View 2 chunks +1 line, -1 line 0 comments Download
M public/web/WebDocument.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + public/web/WebElementCollection.h View 4 chunks +10 lines, -9 lines 0 comments Download
M public/web/WebInputElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M public/web/WebNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M public/web/WebNodeCollection.h View 1 chunk +2 lines, -40 lines 0 comments Download
M public/web/WebNodeList.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 10 months ago (2014-02-04 17:16:50 UTC) #1
tkent
lgtm
6 years, 10 months ago (2014-02-05 02:31:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/152243003/1
6 years, 10 months ago (2014-02-05 03:43:18 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 04:49:17 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=25725
6 years, 10 months ago (2014-02-05 04:49:17 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-05 13:24:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/152243003/1
6 years, 10 months ago (2014-02-05 13:24:17 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 14:48:24 UTC) #8
Message was sent while issue was closed. 
Change committed as 166500

Powered by Google App Engine
This is Rietveld 408576698