Source/web/WebNode.cpp - Issue 152243003: Rename WebNodeCollection to WebElementCollection for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebNode.cpp

Issue 152243003: Rename WebNodeCollection to WebElementCollection for clarity (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebNode.cpp

diff --git a/Source/web/WebNode.cpp b/Source/web/WebNode.cpp

index ba4168ea944a262105a6119d8d94607a364ebe43..780cc6ea179a70a11aa6d6f419cc900baaeb55d3 100644

--- a/Source/web/WebNode.cpp

+++ b/Source/web/WebNode.cpp

@@ -37,8 +37,8 @@

#include "WebDOMEventListener.h"

#include "WebDocument.h"

#include "WebElement.h"

+#include "WebElementCollection.h"

#include "WebFrameImpl.h"

-#include "WebNodeCollection.h"

#include "WebNodeList.h"

#include "WebPluginContainer.h"

#include "WebPluginContainerImpl.h"

@@ -192,11 +192,11 @@ void WebNode::simulateClick()

m_private->dispatchSimulatedClick(0);

}

-WebNodeCollection WebNode::getElementsByTagName(const WebString& tag) const

+WebElementCollection WebNode::getElementsByTagName(const WebString& tag) const

{

if (m_private->isContainerNode())

- return WebNodeCollection(toContainerNode(m_private.get())->getElementsByTagName(tag));

- return WebNodeCollection();

+ return WebElementCollection(toContainerNode(m_private.get())->getElementsByTagName(tag));

+ return WebElementCollection();

}

WebElement WebNode::querySelector(const WebString& tag, WebExceptionCode& ec) const

« no previous file with comments | « Source/web/WebInputElement.cpp ('k') | Source/web/WebNodeCollection.cpp » ('j') | no next file with comments »