Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/objects-debug.cc

Issue 1522413002: [field type tracking] Fix handling of cleared WeakCells. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index b512c1e9c2f843b8ef2db2cbc21d82107a7eddb4..a05d1e703626b125635e9ce15ea935164545023d 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -301,7 +301,11 @@ void JSObject::JSObjectVerify() {
if (r.IsNone()) {
CHECK(type_is_none);
} else if (!type_is_any && !(type_is_none && r.IsHeapObject())) {
- CHECK(!field_type->NowStable() || field_type->NowContains(value));
+ // If allocation folding is off then GC could happen during inner
+ // object literal creation and we will end up having and undefined
+ // value that does not match the field type.
+ CHECK(!field_type->NowStable() || field_type->NowContains(value) ||
+ (!FLAG_use_allocation_folding && value->IsUndefined()));
}
}
}
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698