Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1522273003: [debugger] remove some dead code. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove some dead code. credits to gcov. R=cbruni@chromium.org Committed: https://crrev.com/b68f7e4c336bb307d0af216c96a494fc1a883cdc Cr-Commit-Position: refs/heads/master@{#32877}

Patch Set 1 #

Patch Set 2 : exclude debugger statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M src/debug/debug.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/debug.cc View 1 2 chunks +3 lines, -12 lines 0 comments Download
M src/debug/debug-frames.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug/debug-frames.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
5 years ago (2015-12-15 10:01:35 UTC) #1
Camillo Bruni
lgtm
5 years ago (2015-12-15 13:54:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522273003/1
5 years ago (2015-12-15 14:17:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/13122)
5 years ago (2015-12-15 14:34:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522273003/20001
5 years ago (2015-12-16 05:50:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 06:32:46 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 06:33:13 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b68f7e4c336bb307d0af216c96a494fc1a883cdc
Cr-Commit-Position: refs/heads/master@{#32877}

Powered by Google App Engine
This is Rietveld 408576698