Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: src/debug/debug.cc

Issue 1522273003: [debugger] remove some dead code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: exclude debugger statement Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.h ('k') | src/debug/debug-frames.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 094fd609c346c83029af89efcd7d06dac75883cc..2aac6aa117d54f1e5908170dea5ae20f2fc1dd9d 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -300,10 +300,9 @@ void BreakLocation::ClearDebugBreak() {
bool BreakLocation::IsDebugBreak() const {
- if (IsDebugBreakSlot()) {
- return rinfo().IsPatchedDebugBreakSlotSequence();
- }
- return false;
+ if (IsDebuggerStatement()) return false;
+ DCHECK(IsDebugBreakSlot());
+ return rinfo().IsPatchedDebugBreakSlotSequence();
}
@@ -987,14 +986,6 @@ bool Debug::StepNextContinue(BreakLocation* break_location,
}
-// Check whether the code object at the specified address is a debug break code
-// object.
-bool Debug::IsDebugBreak(Address addr) {
- Code* code = Code::GetCodeFromTargetAddress(addr);
- return code->is_debug_stub();
-}
-
-
// Simple function for returning the source positions for active break points.
Handle<Object> Debug::GetSourceBreakLocations(
Handle<SharedFunctionInfo> shared,
« no previous file with comments | « src/debug/debug.h ('k') | src/debug/debug-frames.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698