Issue 1522123002: Ensure that summary builders aren't used after call to finish()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1522123002: Ensure that summary builders aren't used after call to finish() (Closed)

Created:
5 years ago by Paul Berry

Modified:
5 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Ensure that summary builders aren't used after call to finish() R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/9cff7ca4048a6d69441d6824e45a5be855480fc8

Patch Set 1 #

Total comments: 1

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -21 lines)			Patch
	M	pkg/analyzer/lib/src/summary/format.dart	View		84 chunks	+223 lines, -20 lines	1 comment	Download
	M	pkg/analyzer/tool/summary/generate.dart	View		3 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1522123002/diff/1/pkg/analyzer/lib/src/summary/format.dart File pkg/analyzer/lib/src/summary/format.dart (right): https://codereview.chromium.org/1522123002/diff/1/pkg/analyzer/lib/src/summary/format.dart#newcode45 pkg/analyzer/lib/src/summary/format.dart:45: bool _finished = false; Might be cleaner to ...

5 years ago (2015-12-14 16:54:01 UTC) #3

Paul Berry

5 years ago (2015-12-14 16:59:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9cff7ca4048a6d69441d6824e45a5be855480fc8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages