Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: pkg/analyzer/tool/summary/generate.dart

Issue 1522123002: Ensure that summary builders aren't used after call to finish() (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/tool/summary/generate.dart
diff --git a/pkg/analyzer/tool/summary/generate.dart b/pkg/analyzer/tool/summary/generate.dart
index 186a1010d691533a75fce83bfc79af10c3cd5109..03593db7554fe86032e9483ea3b51e0df9709caf 100644
--- a/pkg/analyzer/tool/summary/generate.dart
+++ b/pkg/analyzer/tool/summary/generate.dart
@@ -307,6 +307,8 @@ class _CodeGenerator {
indent(() {
out('final Map _json = {};');
out();
+ out('bool _finished = false;');
+ out();
out('${name}Builder(builder.BuilderContext context);');
cls.fields.forEach((String fieldName, idlModel.FieldType type) {
out();
@@ -328,6 +330,7 @@ class _CodeGenerator {
builderParams.add('${encodedType(type)} $fieldName');
out('void set $fieldName(${encodedType(type)} _value) {');
indent(() {
+ out('assert(!_finished);');
out('assert(!_json.containsKey(${quoted(fieldName)}));');
out('if (_value != null$condition) {');
indent(() {
@@ -342,7 +345,13 @@ class _CodeGenerator {
out('List<int> toBuffer() => UTF8.encode(JSON.encode(finish()));');
}
out();
- out('Map finish() => _json;');
+ out('Map finish() {');
+ indent(() {
+ out('assert(!_finished);');
+ out('_finished = true;');
+ out('return _json;');
+ });
+ out('}');
});
out('}');
out();
« pkg/analyzer/lib/src/summary/format.dart ('K') | « pkg/analyzer/lib/src/summary/format.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698