Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 152153002: Fix valgrind issue in SkBase64Test.cpp (Closed)

Created:
6 years, 10 months ago by robertphillips
Modified:
6 years, 10 months ago
Reviewers:
tfarina
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This addresses the valgrind issue: Conditional jump or move depends on uninitialised value(s) at 0x636528: SkBase64::decode(void const*, unsigned long, bool) (SkBase64.cpp:63) by 0x6367AC: SkBase64::decode(char const*, unsigned long) (SkBase64.cpp:157) by 0x4865F2: SkBase64Test(skiatest::Reporter*) (SkBase64Test.cpp:24) by 0x486703: skiatest::SkBase64TestClass::onRun(skiatest::Reporter*) (SkBase64Test.cpp:12) by 0x48E48A: skiatest::Test::run() (Test.cpp:105) introduced in r13254 (Port SkBase64 test to our test driver - https://codereview.chromium.org/132233060) TBR=tfarina@chromium.org

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tests/SkBase64Test.cpp View 1 chunk +3 lines, -2 lines 4 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
6 years, 10 months ago (2014-02-01 15:04:55 UTC) #1
robertphillips
committed as r13276
6 years, 10 months ago (2014-02-01 15:45:37 UTC) #2
tfarina
lgtm https://codereview.chromium.org/152153002/diff/1/tests/SkBase64Test.cpp File tests/SkBase64Test.cpp (right): https://codereview.chromium.org/152153002/diff/1/tests/SkBase64Test.cpp#newcode14 tests/SkBase64Test.cpp:14: for (int index = 0; index < 256; ...
6 years, 10 months ago (2014-02-01 15:46:21 UTC) #3
robertphillips
6 years, 10 months ago (2014-02-01 15:50:23 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/152153002/diff/1/tests/SkBase64Test.cpp
File tests/SkBase64Test.cpp (right):

https://codereview.chromium.org/152153002/diff/1/tests/SkBase64Test.cpp#newco...
tests/SkBase64Test.cpp:14: for (int index = 0; index < 256; ++index) {
In this case it doesn't make any performance difference and is more of a style
thing. For actual class based iterators pre vs. post increment/decrement could
make a difference.

https://codereview.chromium.org/152153002/diff/1/tests/SkBase64Test.cpp#newco...
tests/SkBase64Test.cpp:23: src[encodeLength] = '\0';
Yep - np. The recent noise on the valgrind bot hid this yesterday.

Powered by Google App Engine
This is Rietveld 408576698