Issue 1521473003: Merge to XFA: Fix integer and bounds issues in sycc4{22,44}_to_rgb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1521473003: Merge to XFA: Fix integer and bounds issues in sycc4{22,44}_to_rgb. (Closed)

Created:
5 years ago by Oliver Chang

Modified:
5 years ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix integer and bounds issues in sycc4{22,44}_to_rgb. Also clean up while we're here. BUG=557223 TBR=tsepez@chromium.org Original Review URL: https://codereview.chromium.org/1512833008 . (cherry picked from commit 08750d0400f1635ac33c3234cb11b192f31a1eeb) Committed: https://pdfium.googlesource.com/pdfium/+/b9882f4fbcc5f6a9cea49f5c2ec6b91aafac1032

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -36 lines)			Patch
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_jpx_opj.cpp	View	3 chunks	+40 lines, -36 lines	0 comments	Download
A	testing/resources/bug_557223.in	View	Binary file		0 comments	Download
A	testing/resources/bug_557223.pdf	View	Binary file		0 comments	Download

Total messages: 3 (1 generated)

Oliver Chang

5 years ago (2015-12-10 23:59:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b9882f4fbcc5f6a9cea49f5c2ec6b91aafac1032 (presubmit successful).