Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1521423003: Revert of TaskGraphRunner Group support (Closed)

Created:
5 years ago by yoichio
Modified:
5 years ago
Reviewers:
reveman, no sievers, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of TaskGraphRunner Group support (patchset #11 id:340001 of https://codereview.chromium.org/1489233003/ ) Reason for revert: This might cause test failure on SynchronousTaskGraphRunner/SingleThreadTaskGraphRunnerTest/ http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=SynchronousTaskGraphRunner%2FSingleThreadTaskGraphRunnerTest%2F0.Priority&testType=cc_unittests Original issue's description: > TaskGraphRunner Group support > > Adds a group to TaskGraphRunner, this can be used by an > implementation along with priority in order to decide how to execute > tasks. > > This is a prerequisite patch for thread affinity changes which are > coming in a follow-up. > > This patch causes a moderate (~15%) regression in cc_perftests for TaskGraphRunner. > > The main regressions I'm seeing are: > > In ScheduleTasks, we're seeing an additional 3% time spent in operator[] for the two new maps vs ToT. > > We're also seeing an additional 5.5% of time spent in test code which builds the task graph. > > Other regressions are less clear, but probably have to do with the additional cost of ScheduleTasks in the function body itself (inlined looping). > > BUG= > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/05ca4bc9df381e6345f9cf7ee29cdfa075be30c4 > Cr-Commit-Position: refs/heads/master@{#365140} TBR=reveman@chromium.org,sievers@chromium.org,ericrk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/816bb5c6abd09d3fc79d3e76152424092f0735d6 Cr-Commit-Position: refs/heads/master@{#365147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -346 lines) Patch
M cc/cc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/raster/single_thread_task_graph_runner.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/raster/single_thread_task_graph_runner.cc View 3 chunks +5 lines, -18 lines 0 comments Download
M cc/raster/synchronous_task_graph_runner.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/raster/synchronous_task_graph_runner.cc View 4 chunks +5 lines, -23 lines 0 comments Download
M cc/raster/task_graph_runner.h View 1 chunk +7 lines, -17 lines 0 comments Download
M cc/raster/task_graph_runner_perftest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/raster/task_graph_work_queue.h View 8 chunks +28 lines, -53 lines 0 comments Download
M cc/raster/task_graph_work_queue.cc View 7 chunks +50 lines, -114 lines 0 comments Download
M cc/raster/tile_task_worker_pool_perftest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/task_graph_runner_test_template.h View 8 chunks +11 lines, -67 lines 0 comments Download
M cc/test/task_graph_runner_test_template.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/raster_worker_pool.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/raster_worker_pool.cc View 7 chunks +7 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
yoichio
Created Revert of TaskGraphRunner Group support
5 years ago (2015-12-15 04:26:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521423003/1
5 years ago (2015-12-15 04:27:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 04:29:04 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-15 04:30:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/816bb5c6abd09d3fc79d3e76152424092f0735d6
Cr-Commit-Position: refs/heads/master@{#365147}

Powered by Google App Engine
This is Rietveld 408576698