Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: cc/test/task_graph_runner_test_template.h

Issue 1521423003: Revert of TaskGraphRunner Group support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/raster/tile_task_worker_pool_unittest.cc ('k') | cc/test/task_graph_runner_test_template.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/task_graph_runner_test_template.h
diff --git a/cc/test/task_graph_runner_test_template.h b/cc/test/task_graph_runner_test_template.h
index d4175433a02e2a9076028361deea60ab6c7548af..d3989b9cae0c7e9a087c26793e2d1a1de8d58350 100644
--- a/cc/test/task_graph_runner_test_template.h
+++ b/cc/test/task_graph_runner_test_template.h
@@ -24,20 +24,17 @@
unsigned id,
unsigned dependent_id,
unsigned dependent_count,
- unsigned category,
unsigned priority)
: namespace_index(namespace_index),
id(id),
dependent_id(dependent_id),
dependent_count(dependent_count),
- category(category),
priority(priority) {}
int namespace_index;
unsigned id;
unsigned dependent_id;
unsigned dependent_count;
- unsigned category;
unsigned priority;
};
@@ -129,8 +126,8 @@
EXPECT_EQ(0u, this->run_task_ids(i).size());
EXPECT_EQ(0u, this->on_task_completed_ids(i).size());
- this->ScheduleTasks(
- i, std::vector<TaskInfo>(1, TaskInfo(i, 0u, 0u, 0u, 0u, 0u)));
+ this->ScheduleTasks(i,
+ std::vector<TaskInfo>(1, TaskInfo(i, 0u, 0u, 0u, 0u)));
}
for (int i = 0; i < kNamespaceCount; ++i) {
@@ -141,8 +138,8 @@
}
for (int i = 0; i < kNamespaceCount; ++i)
- this->ScheduleTasks(
- i, std::vector<TaskInfo>(1, TaskInfo(i, 0u, 0u, 1u, 0u, 0u)));
+ this->ScheduleTasks(i,
+ std::vector<TaskInfo>(1, TaskInfo(i, 0u, 0u, 1u, 0u)));
for (int i = 0; i < kNamespaceCount; ++i) {
this->RunAllTasks(i);
@@ -152,8 +149,8 @@
}
for (int i = 0; i < kNamespaceCount; ++i)
- this->ScheduleTasks(
- i, std::vector<TaskInfo>(1, TaskInfo(i, 0u, 0u, 2u, 0u, 0u)));
+ this->ScheduleTasks(i,
+ std::vector<TaskInfo>(1, TaskInfo(i, 0u, 0u, 2u, 0u)));
for (int i = 0; i < kNamespaceCount; ++i) {
this->RunAllTasks(i);
@@ -170,7 +167,7 @@
for (int i = 0; i < kNamespaceCount; ++i) {
this->ScheduleTasks(i, std::vector<TaskInfo>(1, TaskInfo(i, 0u, 1u,
1u, // 1 dependent
- 0u, 0u)));
+ 0u)));
}
for (int i = 0; i < kNamespaceCount; ++i) {
@@ -188,7 +185,7 @@
this->ScheduleTasks(i,
std::vector<TaskInfo>(1, TaskInfo(i, 2u, 3u,
2u, // 2 dependents
- 0u, 0u)));
+ 0u)));
}
for (int i = 0; i < kNamespaceCount; ++i) {
@@ -204,60 +201,7 @@
}
}
-TYPED_TEST_P(TaskGraphRunnerTest, Categorys) {
- const int kNamespaceCount = TaskGraphRunnerTestBase::kNamespaceCount;
- const unsigned kCategoryCount = 3;
- using TaskInfo = TaskGraphRunnerTestBase::TaskInfo;
-
- for (int i = 0; i < kNamespaceCount; ++i) {
- EXPECT_EQ(0u, this->run_task_ids(i).size());
- EXPECT_EQ(0u, this->on_task_completed_ids(i).size());
- std::vector<TaskInfo> tasks;
- for (unsigned j = 0; j < kCategoryCount; ++j) {
- tasks.emplace_back(i, 0u, 0u, 0u, j, 0u);
- }
- this->ScheduleTasks(i, tasks);
- }
-
- for (int i = 0; i < kNamespaceCount; ++i) {
- this->RunAllTasks(i);
-
- EXPECT_EQ(kCategoryCount, this->run_task_ids(i).size());
- EXPECT_EQ(kCategoryCount, this->on_task_completed_ids(i).size());
- }
-
- for (int i = 0; i < kNamespaceCount; ++i) {
- std::vector<TaskInfo> tasks;
- for (unsigned j = 0; j < kCategoryCount; ++j) {
- tasks.emplace_back(i, 0u, 0u, 1u, j, 0u);
- }
- this->ScheduleTasks(i, tasks);
- }
-
- for (int i = 0; i < kNamespaceCount; ++i) {
- this->RunAllTasks(i);
-
- EXPECT_EQ(kCategoryCount * 3u, this->run_task_ids(i).size());
- EXPECT_EQ(kCategoryCount * 2u, this->on_task_completed_ids(i).size());
- }
-
- for (int i = 0; i < kNamespaceCount; ++i) {
- std::vector<TaskInfo> tasks;
- for (unsigned j = 0; j < kCategoryCount; ++j) {
- tasks.emplace_back(i, 0u, 0u, 2u, j, 0u);
- }
- this->ScheduleTasks(i, tasks);
- }
-
- for (int i = 0; i < kNamespaceCount; ++i) {
- this->RunAllTasks(i);
-
- EXPECT_EQ(kCategoryCount * 6u, this->run_task_ids(i).size());
- EXPECT_EQ(kCategoryCount * 3u, this->on_task_completed_ids(i).size());
- }
-}
-
-REGISTER_TYPED_TEST_CASE_P(TaskGraphRunnerTest, Basic, Dependencies, Categorys);
+REGISTER_TYPED_TEST_CASE_P(TaskGraphRunnerTest, Basic, Dependencies);
template <typename TaskRunnerTestDelegate>
using SingleThreadTaskGraphRunnerTest =
@@ -271,8 +215,8 @@
for (int i = 0; i < kNamespaceCount; ++i) {
TaskInfo tasks[] = {
- TaskInfo(i, 0u, 2u, 1u, 0u, 1u), // Priority 1
- TaskInfo(i, 1u, 3u, 1u, 0u, 0u) // Priority 0
+ TaskInfo(i, 0u, 2u, 1u, 1u), // Priority 1
+ TaskInfo(i, 1u, 3u, 1u, 0u) // Priority 0
};
this->ScheduleTasks(i,
std::vector<TaskInfo>(tasks, tasks + arraysize(tasks)));
« no previous file with comments | « cc/raster/tile_task_worker_pool_unittest.cc ('k') | cc/test/task_graph_runner_test_template.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698