Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1521413002: Upstream forked safe browsing string on iOS. (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream forked safe browsing string on iOS. BUG=567727 Committed: https://crrev.com/e46dfd0a5dcaecb13c56c5a4c844dd4a8b08b6e6 Cr-Commit-Position: refs/heads/master@{#365001}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename strings to use iOS naming convention #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sdefresne
Please take a look.
5 years ago (2015-12-14 10:33:58 UTC) #2
droger
lgtm https://codereview.chromium.org/1521413002/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/1521413002/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode224 ios/chrome/app/strings/ios_strings.grd:224: <message name="IDS_HARMFUL_V3_EXPLANATION_PARAGRAPH" desc="The explanation of why Safe Browsing ...
5 years ago (2015-12-14 10:51:39 UTC) #3
sdefresne
On 2015/12/14 at 10:51:39, droger wrote: > lgtm > > https://codereview.chromium.org/1521413002/diff/1/ios/chrome/app/strings/ios_strings.grd > File ios/chrome/app/strings/ios_strings.grd (right): ...
5 years ago (2015-12-14 10:56:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521413002/20001
5 years ago (2015-12-14 10:57:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 11:26:16 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-14 11:27:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e46dfd0a5dcaecb13c56c5a4c844dd4a8b08b6e6
Cr-Commit-Position: refs/heads/master@{#365001}

Powered by Google App Engine
This is Rietveld 408576698