Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152133008: Test VS2013 rollout on master.chromium.swarm. (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Test VS2013 rollout on master.chromium.swarm. BUG=309197 R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=249074

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M masters/master.chromium.swarm/master.cfg View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 10 months ago (2014-02-05 19:00:46 UTC) #1
M-A Ruel
lgtm once properly sorted at both place. https://codereview.chromium.org/152133008/diff/1/masters/master.chromium.swarm/master.cfg File masters/master.chromium.swarm/master.cfg (right): https://codereview.chromium.org/152133008/diff/1/masters/master.chromium.swarm/master.cfg#newcode173 masters/master.chromium.swarm/master.cfg:173: 'DEPOT_TOOLS_WIN_TOOLCHAIN': '1', ...
6 years, 10 months ago (2014-02-05 19:21:14 UTC) #2
scottmg
https://codereview.chromium.org/152133008/diff/1/masters/master.chromium.swarm/master.cfg File masters/master.chromium.swarm/master.cfg (right): https://codereview.chromium.org/152133008/diff/1/masters/master.chromium.swarm/master.cfg#newcode173 masters/master.chromium.swarm/master.cfg:173: 'DEPOT_TOOLS_WIN_TOOLCHAIN': '1', On 2014/02/05 19:21:14, M-A Ruel wrote: > ...
6 years, 10 months ago (2014-02-05 19:23:31 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-05 19:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/152133008/20002
6 years, 10 months ago (2014-02-05 19:24:10 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 19:24:45 UTC) #6
Message was sent while issue was closed. 
Change committed as 249074

Powered by Google App Engine
This is Rietveld 408576698