Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.gypi

Issue 152133007: [MIPS] Support for MIPS PNaCl in PPAPI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/plugin.gypi
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.gypi b/ppapi/native_client/src/trusted/plugin/plugin.gypi
index 7f3bff4140273b4faf91bdf42a2263fe48fb10cf..60c396fd7b58b6ef94b0d0129d5795db4c997793 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.gypi
+++ b/ppapi/native_client/src/trusted/plugin/plugin.gypi
@@ -27,14 +27,17 @@
],
# Append the arch-specific ISA code to common_sources.
'conditions': [
- # Note: this test assumes that if this is not an ARM build, then this is
- # is an x86 build. This is because |target_arch| for x86 can be one of a
- # number of values (x64, ia32, etc.).
['target_arch=="arm"', {
'common_sources': [
'arch_arm/sandbox_isa.cc',
],
- }, { # else: 'target_arch != "arm"
+ }],
+ ['target_arch=="mipsel"', {
dmichael (off chromium) 2014/02/05 23:55:22 So am I correct in understanding that you're only
petarj 2014/02/06 00:38:48 Correct.
+ 'common_sources': [
+ 'arch_mips/sandbox_isa.cc',
+ ],
+ }],
+ ['target_arch=="ia32" or target_arch=="x64"', {
'common_sources': [
'arch_x86/sandbox_isa.cc',
],

Powered by Google App Engine
This is Rietveld 408576698