Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.cc

Issue 152133007: [MIPS] Support for MIPS PNaCl in PPAPI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/plugin.cc
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.cc b/ppapi/native_client/src/trusted/plugin/plugin.cc
index f7ee74b524a9b560e97ed523cc158065f968f332..c944a1a0c7d6257e6228b4ec71ca93d6069ee986 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.cc
+++ b/ppapi/native_client/src/trusted/plugin/plugin.cc
@@ -221,6 +221,7 @@ void Plugin::HistogramEnumerateOsArch(const std::string& sandbox_isa) {
kNaClLinux32 = 0,
kNaClLinux64,
kNaClLinuxArm,
+ kNaClLinuxMips,
kNaClMac32,
kNaClMac64,
kNaClMacArm,
dmichael (off chromium) 2014/02/05 23:55:22 I believe these enum values have to be stable, so
petarj 2014/02/06 00:38:48 Done.
jvoung (off chromium) 2014/02/06 00:39:56 I think we need to update server to know of the ne
@@ -243,6 +244,8 @@ void Plugin::HistogramEnumerateOsArch(const std::string& sandbox_isa) {
os_arch = static_cast<NaClOSArch>(os_arch + 1);
if (sandbox_isa == "arm")
os_arch = static_cast<NaClOSArch>(os_arch + 2);
+ if (sandbox_isa == "mips")
+ os_arch = static_cast<NaClOSArch>(os_arch + 3);
dmichael (off chromium) 2014/02/05 23:55:22 If mips only makes sense on linux, maybe you shoul
petarj 2014/02/06 00:38:48 Done.
HistogramEnumerate("NaCl.Client.OSArch", os_arch, kNaClOSArchMax, -1);
}

Powered by Google App Engine
This is Rietveld 408576698