[MIPS] Support for MIPS PNaCl in PPAPI

ppapi/native_client/src/trusted/plugin/plugin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifdef _MSC_VER
 // Do not warn about use of std::copy with raw pointers.
 #pragma warning(disable : 4996)
 #endif
 
 #include "ppapi/native_client/src/trusted/plugin/plugin.h"
@@ skipping 203 matching lines @@
       sample = out_of_range_replacement;
   }
   uma_interface_.HistogramEnumeration(name, sample, maximum);
 }
 
 void Plugin::HistogramEnumerateOsArch(const std::string& sandbox_isa) {
   enum NaClOSArch {
     kNaClLinux32 = 0,
     kNaClLinux64,
     kNaClLinuxArm,
+    kNaClLinuxMips,
     kNaClMac32,
     kNaClMac64,
     kNaClMacArm,

[dmichael (off chromium), 2014/02/05 23:55:22]

I believe these enum values have to be stable, so I think Mips has to go at the
end, just before kNaClOSArchMax.

[petarj, 2014/02/06 00:38:48]

Done.

[jvoung (off chromium), 2014/02/06 00:39:56]

I think we need to update server to know of the new UMA value too

     kNaClWin32,
     kNaClWin64,
     kNaClWinArm,
     kNaClOSArchMax
   };
 
   NaClOSArch os_arch = kNaClOSArchMax;
 #if NACL_LINUX
   os_arch = kNaClLinux32;
 #elif NACL_OSX
   os_arch = kNaClMac32;
 #elif NACL_WINDOWS
   os_arch = kNaClWin32;
 #endif
 
   if (sandbox_isa == "x86-64")
     os_arch = static_cast<NaClOSArch>(os_arch + 1);
   if (sandbox_isa == "arm")
     os_arch = static_cast<NaClOSArch>(os_arch + 2);
+  if (sandbox_isa == "mips")
+    os_arch = static_cast<NaClOSArch>(os_arch + 3);

[dmichael (off chromium), 2014/02/05 23:55:22]

If mips only makes sense on linux, maybe you should just set it explicitly to
kNaClLinuxMips here.

[petarj, 2014/02/06 00:38:48]

Done.

 
   HistogramEnumerate("NaCl.Client.OSArch", os_arch, kNaClOSArchMax, -1);
 }
 
 void Plugin::HistogramEnumerateLoadStatus(PluginErrorCode error_code,
                                           bool is_installed) {
   HistogramEnumerate("NaCl.LoadStatus.Plugin", error_code, ERROR_MAX,
                      ERROR_UNKNOWN);
 
   // Gather data to see if being installed changes load outcomes.
@@ skipping 1322 matching lines @@
   DCHECK(pp::Module::Get()->core()->IsMainThread());
   DCHECK(nacl_interface_);
   exit_status_ = exit_status;
   nacl_interface_->SetReadOnlyProperty(pp_instance(),
                                        pp::Var("exitStatus").pp_var(),
                                        pp::Var(exit_status_).pp_var());
 }
 
 
 }  // namespace plugin