src/a64/lithium-codegen-a64.cc - Issue 152133003: A64: Add support for SMI representation to MulConstI. Also add a test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/lithium-codegen-a64.cc

Issue 152133003: A64: Add support for SMI representation to MulConstI. Also add a test. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/a64/lithium-codegen-a64.cc

diff --git a/src/a64/lithium-codegen-a64.cc b/src/a64/lithium-codegen-a64.cc

index 1ae2e1235fe5331555adaea22ebc7795054f03a3..a891fdf6d25f180ea991061874608d6dd9469176 100644

--- a/src/a64/lithium-codegen-a64.cc

+++ b/src/a64/lithium-codegen-a64.cc

@@ -4154,10 +4154,12 @@ void LCodeGen::DoModI(LModI* instr) {

void LCodeGen::DoMulConstI(LMulConstI* instr) {

jbramley 2014/02/03 15:46:32 Since it now handles smis, could you rename it to

- // TODO(jbramley): Support smi operations (or make a separate DoMulConstS).

- Register result = ToRegister32(instr->result());

- Register left = ToRegister32(instr->left());

+ ASSERT(instr->hydrogen()->representation().IsSmiOrInteger32());

+ bool is_smi = instr->hydrogen()->representation().IsSmi();

+ Register result =

+ is_smi ? ToRegister(instr->result()) : ToRegister32(instr->result());

+ Register left =

+ is_smi ? ToRegister(instr->left()) : ToRegister32(instr->left()) ;

int32_t right = ToInteger32(instr->right());

bool can_overflow = instr->hydrogen()->CheckFlag(HValue::kCanOverflow);

« no previous file with comments | « src/a64/lithium-a64.cc ('k') | test/mjsunit/smi-mul-const.js » ('j') | no next file with comments »