Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 152133003: A64: Add support for SMI representation to MulConstI. Also add a test. (Closed)

Created:
6 years, 10 months ago by rmcilroy
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Add support for SMI representation to MulConstI. Also add a test. R=jacob.bramley@arm.com Committed: https://code.google.com/p/v8/source/detail?r=19036

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename LMulConstI to LMulConstIS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -33 lines) Patch
M src/a64/lithium-a64.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/a64/lithium-a64.cc View 1 2 chunks +15 lines, -24 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download
A test/mjsunit/smi-mul-const.js View 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmcilroy
SMI versions of MulConst won't be hit until we've re-based up to r16361, and until ...
6 years, 10 months ago (2014-02-03 15:37:40 UTC) #1
jbramley
https://codereview.chromium.org/152133003/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/152133003/diff/1/src/a64/lithium-codegen-a64.cc#newcode4156 src/a64/lithium-codegen-a64.cc:4156: void LCodeGen::DoMulConstI(LMulConstI* instr) { Since it now handles smis, ...
6 years, 10 months ago (2014-02-03 15:46:32 UTC) #2
rmcilroy
On 2014/02/03 15:46:32, jbramley wrote: > https://codereview.chromium.org/152133003/diff/1/src/a64/lithium-codegen-a64.cc > File src/a64/lithium-codegen-a64.cc (right): > > https://codereview.chromium.org/152133003/diff/1/src/a64/lithium-codegen-a64.cc#newcode4156 > ...
6 years, 10 months ago (2014-02-03 15:52:31 UTC) #3
jbramley
lgtm Good stuff.
6 years, 10 months ago (2014-02-03 15:54:22 UTC) #4
rmcilroy
6 years, 10 months ago (2014-02-03 16:49:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698