chrome/chrome_browser.gypi - Issue 1521193002: [Offline pages] Refactor URL conversions from TabAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1521193002: [Offline pages] Refactor URL conversions from TabAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing feedback, updating tests, moving functions to a static class Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/offline_page_utils_unittest.cc ('K') | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | components/offline_pages/offline_page_test_archiver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index f3e968578c53bae46435f43bca756e36c6e1e089..bcb2e13669eda70ad285b5b5bb706978c5bbe116 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1450,13 +1450,15 @@

'browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc',

'browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h',

- 'chrome_browser_bookmark_android_sources': [

+ 'chrome_browser_offline_pages_sources': [

'browser/android/offline_pages/offline_page_bridge.cc',

'browser/android/offline_pages/offline_page_bridge.h',

'browser/android/offline_pages/offline_page_mhtml_archiver.cc',

'browser/android/offline_pages/offline_page_mhtml_archiver.h',

'browser/android/offline_pages/offline_page_model_factory.cc',

'browser/android/offline_pages/offline_page_model_factory.h',

+ 'browser/android/offline_pages/offline_page_utils.cc',

+ 'browser/android/offline_pages/offline_page_utils.h',

'chrome_browser_browser_process_sources': [

'browser/browser_process.cc',

@@ -3749,7 +3751,7 @@

'sources': [

'<@(chrome_browser_android_java_ui_sources)',

- '<@(chrome_browser_bookmark_android_sources)',

+ '<@(chrome_browser_offline_pages_sources)',

'<@(chrome_browser_sync_android_java_ui_sources)',

'<@(chrome_browser_supervised_user_android_java_ui_sources)',

'<@(chrome_browser_ssl_android_java_ui_sources)',