[Offline pages] Refactor URL conversions from TabAndroid

components/offline_pages/offline_page_test_archiver.h

Index: components/offline_pages/offline_page_test_archiver.h
diff --git a/components/offline_pages/offline_page_test_archiver.h b/components/offline_pages/offline_page_test_archiver.h
index 7375c1868d23cf497f1984eab9eae73946fb6a0a..92267b1dc1c136f3ecdfa8071dcc39d5dbe871c0 100644
--- a/components/offline_pages/offline_page_test_archiver.h
+++ b/components/offline_pages/offline_page_test_archiver.h
@@ -49,6 +49,11 @@ class OfflinePageTestArchiver : public OfflinePageArchiver {
   // the process to finish.
   void set_delayed(bool delayed) { delayed_ = delayed; }
 
+  // Allows to explicitly specify a file name for the tests.
+  void set_file_name(const base::FilePath& file_name) {

[dewittj, 2015/12/16 22:20:16]

I think that this be SetFileNameForTest instead.

[jianli, 2015/12/16 23:08:08]

Why not just passing in the constructor?

[fgorski, 2015/12/17 19:00:14]

This is a test helper class so we don't need to add the suffix.
Because it is optional in the same way set_delayed is.
I don't want to modify the constructor, because there are other tests dependent
on this thing. We make a separate patch to change this.

+    file_name_ = file_name;
+  }
+
   bool create_archive_called() const { return create_archive_called_; }
 
  private:
@@ -56,6 +61,7 @@ class OfflinePageTestArchiver : public OfflinePageArchiver {
   Observer* observer_;
   GURL url_;
   base::FilePath archives_dir_;
+  base::FilePath file_name_;

[jianli, 2015/12/16 23:08:08]

nit: we tend to use filename

[fgorski, 2015/12/17 19:00:14]

Done.

   ArchiverResult result_;
   int64 size_to_report_;
   bool create_archive_called_;