Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: components/offline_pages/offline_page_model.cc

Issue 1521193002: [Offline pages] Refactor URL conversions from TabAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing CR feedback Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.cc
diff --git a/components/offline_pages/offline_page_model.cc b/components/offline_pages/offline_page_model.cc
index 71102f7dd4847e136ffaeca43018dfa7b740b207..c30ebeb1f3ea318106988f534937683d9dc712e5 100644
--- a/components/offline_pages/offline_page_model.cc
+++ b/components/offline_pages/offline_page_model.cc
@@ -543,6 +543,7 @@ void OfflinePageModel::OnLoadDone(
FOR_EACH_OBSERVER(Observer, observers_, OfflinePageModelLoaded(this));
+ DVLOG(1) << "Store is loaded by now";
dewittj 2015/12/15 18:30:31 nit: remove the log statements from this file.
fgorski 2015/12/16 21:43:16 Done.
CheckForExternalFileDeletion();
}
@@ -647,6 +648,9 @@ void OfflinePageModel::InformDeletePageDone(const DeletePageCallback& callback,
void OfflinePageModel::OnFindPagesMissingArchiveFile(
const std::vector<int64>* ids_of_pages_missing_archive_file) {
DCHECK(ids_of_pages_missing_archive_file);
+ DVLOG(1) << "Found " << ids_of_pages_missing_archive_file->size()
+ << " page(s) missing an archive file.";
+
if (ids_of_pages_missing_archive_file->empty())
return;
@@ -709,6 +713,7 @@ void OfflinePageModel::OnReloadStoreDoneForClearAll(
void OfflinePageModel::CacheLoadedData(
const std::vector<OfflinePageItem>& offline_pages) {
+ DVLOG(1) << "Caching offline pages, count: " << offline_pages.size();
offline_pages_.clear();
for (const auto& offline_page : offline_pages)
offline_pages_[offline_page.bookmark_id] = offline_page;

Powered by Google App Engine
This is Rietveld 408576698