[Offline pages] Refactor URL conversions from TabAndroid

components/offline_pages/offline_page_model.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_model.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 525 matching lines @@
   for (const auto& delayed_task : delayed_tasks_)
     delayed_task.Run();
   delayed_tasks_.clear();
 
   // If there are pages that are marked for deletion, but not yet deleted and
   // OfflinePageModel gets reloaded. Delete the pages now.
   FinalizePageDeletion();
 
   FOR_EACH_OBSERVER(Observer, observers_, OfflinePageModelLoaded(this));
 
+  DVLOG(1) << "Store is loaded by now";

[dewittj, 2015/12/15 18:30:31]

nit: remove the log statements from this file.

[fgorski, 2015/12/16 21:43:16]

Done.

   CheckForExternalFileDeletion();
 }
 
 void OfflinePageModel::InformSavePageDone(const SavePageCallback& callback,
                                           SavePageResult result) {
   UMA_HISTOGRAM_ENUMERATION(
       "OfflinePages.SavePageResult",
       static_cast<int>(result),
       static_cast<int>(SavePageResult::RESULT_COUNT));
   callback.Run(result);
@@ skipping 84 matching lines @@
       "OfflinePages.DeletePageResult",
       static_cast<int>(result),
       static_cast<int>(DeletePageResult::RESULT_COUNT));
   if (!callback.is_null())
     callback.Run(result);
 }
 
 void OfflinePageModel::OnFindPagesMissingArchiveFile(
     const std::vector<int64>* ids_of_pages_missing_archive_file) {
   DCHECK(ids_of_pages_missing_archive_file);
+  DVLOG(1) << "Found " << ids_of_pages_missing_archive_file->size()
+           << " page(s) missing an archive file.";
+
   if (ids_of_pages_missing_archive_file->empty())
     return;
 
   DeletePageCallback done_callback(
       base::Bind(&OfflinePageModel::OnRemoveOfflinePagesMissingArchiveFileDone,
                  weak_ptr_factory_.GetWeakPtr(),
                  *ids_of_pages_missing_archive_file));
 
   store_->RemoveOfflinePages(
       *ids_of_pages_missing_archive_file,
@@ skipping 42 matching lines @@
       load_status == OfflinePageMetadataStore::LOAD_SUCCEEDED ?
           CLEAR_ALL_SUCCEEDED : STORE_RELOAD_FAILED,
       CLEAR_ALL_STATUS_COUNT);
 
   CacheLoadedData(offline_pages);
   callback.Run();
 }
 
 void OfflinePageModel::CacheLoadedData(
     const std::vector<OfflinePageItem>& offline_pages) {
+  DVLOG(1) << "Caching offline pages, count: " << offline_pages.size();
   offline_pages_.clear();
   for (const auto& offline_page : offline_pages)
     offline_pages_[offline_page.bookmark_id] = offline_page;
 }
 
 }  // namespace offline_pages