chrome/browser/android/offline_pages/offline_page_model_factory.cc - Issue 1521193002: [Offline pages] Refactor URL conversions from TabAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_model_factory.cc

Issue 1521193002: [Offline pages] Refactor URL conversions from TabAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing CR feedback Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | chrome/browser/android/offline_pages/offline_page_utils.h » ('j') | chrome/browser/android/offline_pages/offline_page_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_model_factory.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_model_factory.cc b/chrome/browser/android/offline_pages/offline_page_model_factory.cc

index cb9e9f57a5a3157e59159c368938531d8ba9bbe4..00740fd0b1824a494521bdfb86ff83c74c61b05c 100644

--- a/chrome/browser/android/offline_pages/offline_page_model_factory.cc

+++ b/chrome/browser/android/offline_pages/offline_page_model_factory.cc

@@ -15,6 +15,7 @@

#include "components/offline_pages/offline_page_metadata_store_impl.h"

#include "components/offline_pages/offline_page_model.h"

#include "components/offline_pages/proto/offline_pages.pb.h"

+#include "content/public/browser/browser_context.h"

dewittj 2015/12/15 18:30:31 I think since you aren't dereferencing a pointer y

fgorski 2015/12/16 21:43:16 Done.

#include "content/public/browser/browser_thread.h"

namespace offline_pages {