[Offline pages] Refactor URL conversions from TabAndroid

chrome/browser/android/offline_pages/offline_page_model_factory.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
 
 #include "base/files/file_path.h"
 #include "base/memory/singleton.h"
 #include "base/path_service.h"
 #include "base/sequenced_task_runner.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_constants.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/offline_pages/offline_page_metadata_store_impl.h"
 #include "components/offline_pages/offline_page_model.h"
 #include "components/offline_pages/proto/offline_pages.pb.h"
+#include "content/public/browser/browser_context.h"

[dewittj, 2015/12/15 18:30:31]

I think since you aren't dereferencing a pointer you can just forward declare
the class, rather than including the header file.

[fgorski, 2015/12/16 21:43:16]

Done.

 #include "content/public/browser/browser_thread.h"
 
 namespace offline_pages {
 
 OfflinePageModelFactory::OfflinePageModelFactory()
     : BrowserContextKeyedServiceFactory(
           "OfflinePageModel",
           BrowserContextDependencyManager::GetInstance()) {
 }
 
@@ skipping 28 matching lines @@
                               background_task_runner);
 }
 
 content::BrowserContext* OfflinePageModelFactory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }
 
 }  // namespace offline_pages