Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1521133002: Add CLZ instruction to the ARM integrated assembler. (Closed)

Created:
5 years ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reformat. #

Patch Set 3 : Fix comment in clz.ll #

Total comments: 2

Patch Set 4 : Remove comment in test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -5 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/clz.ll View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
5 years ago (2015-12-11 23:23:54 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1521133002/diff/40001/tests_lit/assembler/arm32/clz.ll File tests_lit/assembler/arm32/clz.ll (right): https://codereview.chromium.org/1521133002/diff/40001/tests_lit/assembler/arm32/clz.ll#newcode3 tests_lit/assembler/arm32/clz.ll:3: ; NOTE: We use -Om1 to get rid ...
5 years ago (2015-12-11 23:44:34 UTC) #4
Karl
Committed patchset #4 (id:60001) manually as 65f80d72389d036abaa3714ca18d95bf59ebb1fa (presubmit successful).
5 years ago (2015-12-17 16:02:24 UTC) #6
Karl
5 years ago (2015-12-17 16:02:41 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1521133002/diff/40001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/clz.ll (right):

https://codereview.chromium.org/1521133002/diff/40001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/clz.ll:3: ; NOTE: We use -Om1 to get rid of memory
stores.
On 2015/12/11 23:44:34, stichnot wrote:
> All the other .ll files with this comment say the -O2 is used to get rid of
> memory stores.  What's the real reason for -Om1 here?
> 
> I assume that as a general principle, Om1 is used to maximize stability of
test
> output, so maybe this comment just gets deleted?

Yes, I wanted to maximize stability in this case. Removing comment.

Powered by Google App Engine
This is Rietveld 408576698