Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1520823002: Revert of MIPS: Enable v8 compilation with CLANG. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS: Enable v8 compilation with CLANG. (patchset #1 id:1 of https://codereview.chromium.org/1519493002/ ) Reason for revert: [Sheriff] This seems to break chromium runhooks for android: https://build.chromium.org/p/client.v8.fyi/builders/Android%20Builder/builds/1794 Original issue's description: > MIPS: Enable v8 compilation with CLANG. > > Updated toolchain.gypi to support v8 using CLANG on MIPS. These changes > include using integrated assembler with CLANG, and disabling options > used by GCC which are not supported by CLANG. > > TEST= > BUG= > > Committed: https://crrev.com/0bae3c393575de4503cb179faa220e597e35dd8f > Cr-Commit-Position: refs/heads/master@{#32780} TBR=paul.lind@imgtec.com,akos.palfi@imgtec.com,balazs.kilvady@imgtec.com,ivica.bogosavljevic@imgtec.com,jkummerow@chromium.org,Ilija.Pavlovic@imgtec.com,Ilija.Pavlovic@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/eaac00b4e7248eefbac07a78f6087713268b616b Cr-Commit-Position: refs/heads/master@{#32781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -69 lines) Patch
M build/toolchain.gypi View 10 chunks +11 lines, -69 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of MIPS: Enable v8 compilation with CLANG.
5 years ago (2015-12-11 09:10:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520823002/1
5 years ago (2015-12-11 09:10:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 09:10:22 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-11 09:10:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaac00b4e7248eefbac07a78f6087713268b616b
Cr-Commit-Position: refs/heads/master@{#32781}

Powered by Google App Engine
This is Rietveld 408576698