cc:: Change plumbing for external_begin_frame_source to the Scheduler.

cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/767dd52f6ff06a70160f1dfa7c0c4dcf6460111f
Cr-Commit-Position: refs/heads/master@{#365460}

[Khushal, 2015-12-10 22:57:58]

Description was changed from

==========
cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
==========

to

==========
cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Khushal, 2015-12-10 22:58:27]

Description was changed from

==========
cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Khushal, 2015-12-10 22:58:27]

khushalsagar@chromium.org changed reviewers:
+ brianderson@chromium.org, vmpstr@chromium.org

[brianderson, 2015-12-10 23:06:02]

lgtm

https://codereview.chromium.org/1520623003/diff/1/cc/trees/proxy_main.cc
File cc/trees/proxy_main.cc (left):

https://codereview.chromium.org/1520623003/diff/1/cc/trees/proxy_main.cc#oldc...
cc/trees/proxy_main.cc:52:
DCHECK(!layer_tree_host_->settings().use_external_begin_frame_source ||
Can you keep this DCHECK in ProxyMain::Start?

https://codereview.chromium.org/1520623003/diff/1/cc/trees/single_thread_proxy.h
File cc/trees/single_thread_proxy.h (right):

https://codereview.chromium.org/1520623003/diff/1/cc/trees/single_thread_prox...
cc/trees/single_thread_proxy.h:143: RenderingStatsInstrumentation*
rendering_stats_instrumentation_;
Don't think these are needed as member variables. They are only used once in
STP::Start and can be accessed from the layer_tree_host_ member variable.

[Khushal, 2015-12-11 02:37:40]

Thanks Brian.
vmpstr@, could you take a look at this as well.

https://codereview.chromium.org/1520623003/diff/1/cc/trees/proxy_main.cc
File cc/trees/proxy_main.cc (left):

https://codereview.chromium.org/1520623003/diff/1/cc/trees/proxy_main.cc#oldc...
cc/trees/proxy_main.cc:52:
DCHECK(!layer_tree_host_->settings().use_external_begin_frame_source ||
On 2015/12/10 23:06:02, brianderson wrote:
> Can you keep this DCHECK in ProxyMain::Start?

Done.

https://codereview.chromium.org/1520623003/diff/1/cc/trees/single_thread_proxy.h
File cc/trees/single_thread_proxy.h (right):

https://codereview.chromium.org/1520623003/diff/1/cc/trees/single_thread_prox...
cc/trees/single_thread_proxy.h:143: RenderingStatsInstrumentation*
rendering_stats_instrumentation_;
On 2015/12/10 23:06:02, brianderson wrote:
> Don't think these are needed as member variables. They are only used once in
> STP::Start and can be accessed from the layer_tree_host_ member variable.

Done. I was thinking along the lines for when we unify the single-threaded case
to use a channel as well. But we pass the LTH to ProxyImpl for initialization as
well so it can pull these values from there then.

[Khushal, 2015-12-16 01:40:19]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2015-12-16 01:40:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianderson@chromium.org
Link to the patchset: https://codereview.chromium.org/1520623003/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-12-16 01:45:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1520623003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1520623003/40001

[commit-bot: I haz the power, 2015-12-16 02:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 02:21:40]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Khushal, 2015-12-16 02:45:02]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2015-12-16 02:45:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianderson@chromium.org
Link to the patchset: https://codereview.chromium.org/1520623003/#ps60001
(title: "Missing include.")

[commit-bot: I haz the power, 2015-12-16 02:49:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1520623003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1520623003/60001

[vmpstr, 2015-12-16 03:46:26]

lgtm

[commit-bot: I haz the power, 2015-12-16 05:14:12]

Description was changed from

==========
cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2015-12-16 05:14:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-16 05:16:02]

Description was changed from

==========
cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc:: Change plumbing for external_begin_frame_source to the Scheduler.

This eliminates the need for the temporary variable in ProxyMain and
makes the initialization set up for the singlethreaded and threade case
identical.

BUG=567930
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/767dd52f6ff06a70160f1dfa7c0c4dcf6460111f
Cr-Commit-Position: refs/heads/master@{#365460}
==========

[commit-bot: I haz the power, 2015-12-16 05:16:03]

Patchset 4 (id:??) landed as
https://crrev.com/767dd52f6ff06a70160f1dfa7c0c4dcf6460111f
Cr-Commit-Position: refs/heads/master@{#365460}