Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3345)

Unified Diff: cc/test/layer_tree_test.cc

Issue 1520623003: cc:: Change plumbing for external_begin_frame_source to the Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missing include. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/fake_proxy.h ('k') | cc/test/proxy_main_for_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/layer_tree_test.cc
diff --git a/cc/test/layer_tree_test.cc b/cc/test/layer_tree_test.cc
index d68ec6744bf8f72135da6a993027cccc369c28b2..3234d45d2aeb0030794176b84aafe69f3cc88a51 100644
--- a/cc/test/layer_tree_test.cc
+++ b/cc/test/layer_tree_test.cc
@@ -99,30 +99,22 @@ void CreateVirtualViewportLayers(Layer* root_layer,
// various actions.
class SingleThreadProxyForTest : public SingleThreadProxy {
public:
- static scoped_ptr<Proxy> Create(
- TestHooks* test_hooks,
- LayerTreeHost* host,
- LayerTreeHostSingleThreadClient* client,
- TaskRunnerProvider* task_runner_provider,
- scoped_ptr<BeginFrameSource> external_begin_frame_source) {
+ static scoped_ptr<Proxy> Create(TestHooks* test_hooks,
+ LayerTreeHost* host,
+ LayerTreeHostSingleThreadClient* client,
+ TaskRunnerProvider* task_runner_provider) {
return make_scoped_ptr(new SingleThreadProxyForTest(
- test_hooks, host, client, task_runner_provider,
- std::move(external_begin_frame_source)));
+ test_hooks, host, client, task_runner_provider));
}
~SingleThreadProxyForTest() override {}
private:
- SingleThreadProxyForTest(
- TestHooks* test_hooks,
- LayerTreeHost* host,
- LayerTreeHostSingleThreadClient* client,
- TaskRunnerProvider* task_runner_provider,
- scoped_ptr<BeginFrameSource> external_begin_frame_source)
- : SingleThreadProxy(host,
- client,
- task_runner_provider,
- std::move(external_begin_frame_source)),
+ SingleThreadProxyForTest(TestHooks* test_hooks,
+ LayerTreeHost* host,
+ LayerTreeHostSingleThreadClient* client,
+ TaskRunnerProvider* task_runner_provider)
+ : SingleThreadProxy(host, client, task_runner_provider),
test_hooks_(test_hooks) {}
void ScheduledActionSendBeginMainFrame(const BeginFrameArgs& args) override {
@@ -457,16 +449,16 @@ class LayerTreeHostForTesting : public LayerTreeHost {
if (mode == CompositorMode::Threaded) {
DCHECK(impl_task_runner.get());
scoped_ptr<ProxyMain> proxy_main = ProxyMainForTest::CreateThreaded(
- test_hooks, layer_tree_host.get(), task_runner_provider.get(),
- std::move(external_begin_frame_source));
+ test_hooks, layer_tree_host.get(), task_runner_provider.get());
proxy = std::move(proxy_main);
} else {
- proxy = SingleThreadProxyForTest::Create(
- test_hooks, layer_tree_host.get(), client, task_runner_provider.get(),
- std::move(external_begin_frame_source));
+ proxy =
+ SingleThreadProxyForTest::Create(test_hooks, layer_tree_host.get(),
+ client, task_runner_provider.get());
}
- layer_tree_host->InitializeForTesting(std::move(task_runner_provider),
- std::move(proxy));
+ layer_tree_host->InitializeForTesting(
+ std::move(task_runner_provider), std::move(proxy),
+ std::move(external_begin_frame_source));
return layer_tree_host;
}
« no previous file with comments | « cc/test/fake_proxy.h ('k') | cc/test/proxy_main_for_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698