Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: BUILD.gn

Issue 1520443002: Fix BUILD.gn to load the correct V8 snapshot configuration (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | samples/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build_overrides/v8.gni")
5 import("//testing/test.gni") 6 import("//testing/test.gni")
6 import("pdfium.gni") 7 import("pdfium.gni")
7 8
8 config("pdfium_config") { 9 config("pdfium_config") {
9 cflags = [] 10 cflags = []
10 include_dirs = [ 11 include_dirs = [
11 ".", 12 ".",
12 "third_party/freetype/include", 13 "third_party/freetype/include",
13 "third_party/freetype/include/freetype", 14 "third_party/freetype/include/freetype",
14 ] 15 ]
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 include_dirs = [] 164 include_dirs = []
164 if (pdf_enable_v8) { 165 if (pdf_enable_v8) {
165 deps += [ 166 deps += [
166 "//v8", 167 "//v8",
167 "//v8:v8_libplatform", 168 "//v8:v8_libplatform",
168 ] 169 ]
169 include_dirs += [ 170 include_dirs += [
170 "//v8", 171 "//v8",
171 "//v8/include", 172 "//v8/include",
172 ] 173 ]
174 configs += [ "//v8:external_startup_data" ]
173 } 175 }
174 configs += [ ":pdfium_config" ] 176 configs += [ ":pdfium_config" ]
175 } 177 }
176 178
177 # Targets below this are only visible within this file (and to the 179 # Targets below this are only visible within this file (and to the
178 # top-level gn_visibility target used to help gn_all build everything). 180 # top-level gn_visibility target used to help gn_all build everything).
179 visibility = [ 181 visibility = [
180 ":*", 182 ":*",
181 "//:gn_visibility", 183 "//:gn_visibility",
182 ] 184 ]
(...skipping 498 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 "fpdfsdk/src/javascript/util.h", 683 "fpdfsdk/src/javascript/util.h",
682 "fpdfsdk/src/jsapi/fxjs_v8.cpp", 684 "fpdfsdk/src/jsapi/fxjs_v8.cpp",
683 ] 685 ]
684 include_dirs = [ 686 include_dirs = [
685 "//v8", 687 "//v8",
686 "//v8/include", 688 "//v8/include",
687 ] 689 ]
688 public_deps = [ 690 public_deps = [
689 "//v8", 691 "//v8",
690 ] 692 ]
693 configs += [ "//v8:external_startup_data" ]
691 } else { 694 } else {
692 sources += [ "fpdfsdk/src/javascript/JS_Runtime_Stub.cpp" ] 695 sources += [ "fpdfsdk/src/javascript/JS_Runtime_Stub.cpp" ]
693 } 696 }
694 configs += [ ":pdfium_config" ] 697 configs += [ ":pdfium_config" ]
695 } 698 }
696 699
697 static_library("formfiller") { 700 static_library("formfiller") {
698 sources = [ 701 sources = [
699 "fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h", 702 "fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h",
700 "fpdfsdk/include/formfiller/FFL_CheckBox.h", 703 "fpdfsdk/include/formfiller/FFL_CheckBox.h",
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
773 if (pdf_enable_v8) { 776 if (pdf_enable_v8) {
774 sources += [ "fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp" ] 777 sources += [ "fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp" ]
775 deps += [ 778 deps += [
776 "//v8", 779 "//v8",
777 "//v8:v8_libplatform", 780 "//v8:v8_libplatform",
778 ] 781 ]
779 include_dirs += [ 782 include_dirs += [
780 "//v8", 783 "//v8",
781 "//v8/include", 784 "//v8/include",
782 ] 785 ]
786 configs += [ "//v8:external_startup_data" ]
783 } 787 }
784 configs += [ ":pdfium_config" ] 788 configs += [ ":pdfium_config" ]
785 } 789 }
OLDNEW
« no previous file with comments | « no previous file | samples/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698