Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1520373002: Deprecate ability to generate stubs via Compiler class. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate ability to generate stubs via Compiler class. This removes the ability to generate stub code via the full-fledged compiler pipeline that parses and analyzes JavaScript source code. Generation of stub code has been moved to a lower-level entry point. R=bmeurer@chromium.org Committed: https://crrev.com/4c7a51d759f651991345bd7b2b8301fb7a854993 Cr-Commit-Position: refs/heads/master@{#32847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -38 lines) Patch
M src/compiler.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/compiler.cc View 3 chunks +0 lines, -26 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years ago (2015-12-14 18:58:36 UTC) #1
Benedikt Meurer
Awesome, LGTM!
5 years ago (2015-12-14 19:09:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520373002/1
5 years ago (2015-12-14 19:10:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 19:19:03 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-14 19:19:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c7a51d759f651991345bd7b2b8301fb7a854993
Cr-Commit-Position: refs/heads/master@{#32847}

Powered by Google App Engine
This is Rietveld 408576698