Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: src/compiler.cc

Issue 1520373002: Deprecate ability to generate stubs via Compiler class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index cf66a02856e9769d1fa827b510c6e4e61fd80003..691ec565a6ddb09fe8e7c4aabb2815f620b3aa88 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -178,7 +178,6 @@ CompilationInfo::CompilationInfo(ParseInfo* parse_info, CodeStub* code_stub,
parameter_count_(0),
optimization_id_(-1),
osr_expr_stack_height_(0),
- function_type_(nullptr),
debug_name_(debug_name) {
// Parameter count is number of stack parameters.
if (code_stub_ != NULL) {
@@ -205,14 +204,6 @@ CompilationInfo::~CompilationInfo() {
}
-void CompilationInfo::SetStub(CodeStub* code_stub) {
- SetMode(STUB);
- code_stub_ = code_stub;
- debug_name_ = CodeStub::MajorName(code_stub->MajorKey());
- set_output_code_kind(code_stub->GetCodeKind());
-}
-
-
int CompilationInfo::num_parameters() const {
return has_scope() ? scope()->num_parameters() : parameter_count_;
}
@@ -998,23 +989,6 @@ MaybeHandle<Code> Compiler::GetLazyCode(Handle<JSFunction> function) {
}
-MaybeHandle<Code> Compiler::GetStubCode(Handle<JSFunction> function,
- CodeStub* stub) {
- // Build a "hybrid" CompilationInfo for a JSFunction/CodeStub pair.
- Zone zone;
- ParseInfo parse_info(&zone, function);
- CompilationInfo info(&parse_info);
- info.SetFunctionType(stub->GetCallInterfaceDescriptor().GetFunctionType());
- info.MarkAsFunctionContextSpecializing();
- info.MarkAsDeoptimizationEnabled();
- info.SetStub(stub);
-
- // Run a "mini pipeline", extracted from compiler.cc.
- if (!ParseAndAnalyze(&parse_info)) return MaybeHandle<Code>();
- return compiler::Pipeline(&info).GenerateCode();
-}
-
-
bool Compiler::Compile(Handle<JSFunction> function, ClearExceptionFlag flag) {
if (function->is_compiled()) return true;
MaybeHandle<Code> maybe_code = Compiler::GetLazyCode(function);
« no previous file with comments | « src/compiler.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698