core/src/fpdftext/fpdf_text_search.cpp - Issue 1520063002: Get rid of most instance of 'foo == NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdftext/fpdf_text_search.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull

Patch Set: self review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdftext/fpdf_text_search.cpp

diff --git a/core/src/fpdftext/fpdf_text_search.cpp b/core/src/fpdftext/fpdf_text_search.cpp

index 0acea11cf2796cc8f85ef1c713074fb8ac65006d..13804dec50ae321372fb7701dcdd17764c1f82fc 100644

--- a/core/src/fpdftext/fpdf_text_search.cpp

+++ b/core/src/fpdftext/fpdf_text_search.cpp

@@ -303,7 +303,7 @@ void GetTextStream_Unicode(CFX_WideTextBuf& buffer,

FX_POSITION pos = pPage->GetFirstObjectPosition();

while (pos) {

CPDF_PageObject* pObject = pPage->GetNextObject(pos);

- if (pObject == NULL) {

+ if (!pObject) {

Tom Sepez 2015/12/14 18:27:00 nit: or just if (pObjext && pObject->m_Type == P

Lei Zhang 2015/12/15 01:58:36 Done.

continue;

}

if (pObject->m_Type != PDFPAGE_TEXT) {