Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: core/src/fpdftext/fpdf_text_search.cpp

Issue 1520063002: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bstr_isnull
Patch Set: self review Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/include/fpdfapi/fpdf_page.h" 7 #include "core/include/fpdfapi/fpdf_page.h"
8 #include "core/include/fpdfapi/fpdf_pageobj.h" 8 #include "core/include/fpdfapi/fpdf_pageobj.h"
9 #include "text_int.h" 9 #include "text_int.h"
10 10
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 return FALSE; 296 return FALSE;
297 } 297 }
298 void GetTextStream_Unicode(CFX_WideTextBuf& buffer, 298 void GetTextStream_Unicode(CFX_WideTextBuf& buffer,
299 CPDF_PageObjects* pPage, 299 CPDF_PageObjects* pPage,
300 FX_BOOL bUseLF, 300 FX_BOOL bUseLF,
301 CFX_PtrArray* pObjArray) { 301 CFX_PtrArray* pObjArray) {
302 CPDF_TextStream textstream(buffer, bUseLF, pObjArray); 302 CPDF_TextStream textstream(buffer, bUseLF, pObjArray);
303 FX_POSITION pos = pPage->GetFirstObjectPosition(); 303 FX_POSITION pos = pPage->GetFirstObjectPosition();
304 while (pos) { 304 while (pos) {
305 CPDF_PageObject* pObject = pPage->GetNextObject(pos); 305 CPDF_PageObject* pObject = pPage->GetNextObject(pos);
306 if (pObject == NULL) { 306 if (!pObject) {
Tom Sepez 2015/12/14 18:27:00 nit: or just if (pObjext && pObject->m_Type == P
Lei Zhang 2015/12/15 01:58:36 Done.
307 continue; 307 continue;
308 } 308 }
309 if (pObject->m_Type != PDFPAGE_TEXT) { 309 if (pObject->m_Type != PDFPAGE_TEXT) {
310 continue; 310 continue;
311 } 311 }
312 textstream.ProcessObject((CPDF_TextObject*)pObject, FALSE); 312 textstream.ProcessObject((CPDF_TextObject*)pObject, FALSE);
313 } 313 }
314 } 314 }
315 CFX_WideString PDF_GetFirstTextLine_Unicode(CPDF_Document* pDoc, 315 CFX_WideString PDF_GetFirstTextLine_Unicode(CPDF_Document* pDoc,
316 CPDF_Dictionary* pPage) { 316 CPDF_Dictionary* pPage) {
(...skipping 11 matching lines...) Expand all
328 CPDF_PageObject* pObject = page.GetNextObject(pos); 328 CPDF_PageObject* pObject = page.GetNextObject(pos);
329 if (pObject->m_Type != PDFPAGE_TEXT) { 329 if (pObject->m_Type != PDFPAGE_TEXT) {
330 continue; 330 continue;
331 } 331 }
332 if (textstream.ProcessObject((CPDF_TextObject*)pObject, TRUE)) { 332 if (textstream.ProcessObject((CPDF_TextObject*)pObject, TRUE)) {
333 break; 333 break;
334 } 334 }
335 } 335 }
336 return buffer.GetWideString(); 336 return buffer.GetWideString();
337 } 337 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698