Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode.html

Issue 151993004: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode.html
diff --git a/LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode.html b/LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode.html
new file mode 100644
index 0000000000000000000000000000000000000000..6c490e82f74ca1ed5494f6b7e7443cd1fd4718c8
--- /dev/null
+++ b/LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode.html
@@ -0,0 +1,44 @@
+<!DOCTYPE html>
+<html>
+ <head>
+ <style>
+ col {
+ height: 200px;
+ }
+ td {
+ background-color: #66f;
+ height: 25px;
+ }
+ </style>
+ <script type="text/javascript">
+ function changeColHeightUsingHeight() {
+ var col = document.getElementById('thecol');
+ col.style.height="100px";
+ window.checkLayout("td", document.getElementById("test-output"));
+ }
+ </script>
+ <script src="../../../resources/check-layout.js"></script>
+ </head>
+ <body>
+ Tests that the height of table cell changes on changing the colgroup height to new height.
Julien - ping for review 2014/02/24 19:25:31 It's the logical width that you are changing, talk
Gurpreet 2014/02/25 13:12:56 Initially was checking for style()->width() instea
Julien - ping for review 2014/03/01 00:27:54 It would be nice to understand why this case was c
+ <table style="-webkit-writing-mode: vertical-lr">
+ <colgroup>
+ <col id="thecol">
+ </colgroup>
+ <tbody>
+ <tr>
+ <td id="colWidth" data-expected-height="100">Hello World</td>
+ </tr>
+ </tbody>
+ </table>
+ <button onclick="changeColHeightUsingHeight();">Click me to test manually. The column should shrink to 100px in height.</button>
+ <div id="test-output"></div>
+ </body>
+ <script>
+ if (window.eventSender) {
+ eventSender.mouseMoveTo(20, 240);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+ }
+ </script>
+</html>

Powered by Google App Engine
This is Rietveld 408576698