LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode.html - Issue 151993004: Col width is not honored when dynamically updated and it would not make table narrower

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode.html

Issue 151993004: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-height-vertical-writing-mode-expected.txt » ('j') | Source/core/rendering/RenderTableCol.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 col {

	6 height: 200px;

	7 }

	8 td {

	9 background-color: #66f;

	10 height: 25px;

	11 }

	12 </style>

	13 <script type="text/javascript">

	14 function changeColHeightUsingHeight() {

	15 var col = document.getElementById('thecol');

	16 col.style.height="100px";

	17 window.checkLayout("td", document.getElementById("test-output")) ;

	18 }

	19 </script>

	20 <script src="../../../resources/check-layout.js"></script>

	21 </head>

	22 <body>

	23 Tests that the height of table cell changes on changing the colgroup hei ght to new height.
	Julien - ping for review 2014/02/24 19:25:31 It's the logical width that you are changing, talk It's the logical width that you are changing, talking about height is right but confusing as we are thinking in terms of the CSS 3 writing mode's abstract box. Gurpreet 2014/02/25 13:12:56 Initially was checking for style()->width() instea Show quoted text On 2014/02/24 19:25:31, Julien Chaffraix - PST wrote: > It's the logical width that you are changing, talking about height is right but > confusing as we are thinking in terms of the CSS 3 writing mode's abstract box. Initially was checking for style()->width() instead of logicalWidth so that would only do for width related changes only as height test case is already working without my changes also. Julien - ping for review 2014/03/01 00:27:54 It would be nice to understand why this case was c Show quoted text On 2014/02/25 13:12:56, Gurpreet wrote: > On 2014/02/24 19:25:31, Julien Chaffraix - PST wrote: > > It's the logical width that you are changing, talking about height is right > but > > confusing as we are thinking in terms of the CSS 3 writing mode's abstract > box. > > Initially was checking for style()->width() instead of logicalWidth so that > would only do for width related changes only as height test case is already > working without my changes also. It would be nice to understand why this case was correct in the first place as it should have had the same issue as the 'width' case.
	24 <table style="-webkit-writing-mode: vertical-lr">

	25 <colgroup>

	26 <col id="thecol">

	27 </colgroup>

	28 <tbody>

	29 <tr>

	30 <td id="colWidth" data-expected-height="100">Hello World</td>

	31 </tr>

	32 </tbody>

	33 </table>

	34 <button onclick="changeColHeightUsingHeight();">Click me to test manuall y. The column should shrink to 100px in height.</button>

	35 <div id="test-output"></div>

	36 </body>

	37 <script>

	38 if (window.eventSender) {

	39 eventSender.mouseMoveTo(20, 240);

	40 eventSender.mouseDown();

	41 eventSender.mouseUp();

	42 }

	43 </script>

	44 </html>

OLD	NEW