Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1519693002: Merge to XFA: Remove CFX_AffineMatrix/CPDF_Matrix (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove CFX_AffineMatrix/CPDF_Matrix Review URL: https://codereview.chromium.org/1513363002 . (cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0) R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/60d909e9d4444b2b8582275624ee97734d331a38

Patch Set 1 : Origial patch #

Patch Set 2 : XFA-specific changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+822 lines, -856 lines) Patch
M core/include/fpdfapi/fpdf_module.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_objects.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/include/fpdfapi/fpdf_page.h View 5 chunks +6 lines, -6 lines 0 comments Download
M core/include/fpdfapi/fpdf_pageobj.h View 11 chunks +17 lines, -19 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 3 chunks +2 lines, -3 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 7 chunks +11 lines, -11 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 6 chunks +10 lines, -10 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 6 chunks +8 lines, -8 lines 0 comments Download
M core/include/fpdftext/fpdf_text.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_coordinates.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxge/fx_dib.h View 4 chunks +6 lines, -6 lines 0 comments Download
M core/include/fxge/fx_font.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/include/fxge/fx_ge.h View 12 chunks +22 lines, -22 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 7 chunks +8 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 5 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 27 chunks +43 lines, -51 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 22 chunks +25 lines, -25 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 17 chunks +28 lines, -30 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 18 chunks +44 lines, -48 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 15 chunks +18 lines, -18 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/text_int.h View 4 chunks +7 lines, -7 lines 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 5 chunks +7 lines, -7 lines 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 9 chunks +19 lines, -21 lines 0 comments Download
M core/src/fxge/apple/apple_int.h View 6 chunks +9 lines, -9 lines 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 4 chunks +12 lines, -13 lines 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 9 chunks +26 lines, -29 lines 0 comments Download
M core/src/fxge/dib/dib_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 5 chunks +8 lines, -9 lines 0 comments Download
M core/src/fxge/ge/fx_ge_device.cpp View 7 chunks +10 lines, -11 lines 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M core/src/fxge/ge/fx_ge_ps.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 9 chunks +16 lines, -17 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.h View 3 chunks +8 lines, -8 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 8 chunks +21 lines, -22 lines 0 comments Download
M core/src/fxge/win32/dwrite_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 7 chunks +12 lines, -13 lines 0 comments Download
M core/src/fxge/win32/win32_int.h View 7 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_PushButton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_page.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 1 5 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Caret.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Label.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListCtrl.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ScrollBar.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Signature.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 4 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 5 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 10 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_PushButton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_page.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Icon.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_IconList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Label.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ScrollBar.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Signature.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 13 chunks +18 lines, -18 lines 0 comments Download
M third_party/agg23/agg_rasterizer_scanline_aa.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/fde/fde_gedevice.cpp View 1 8 chunks +17 lines, -17 lines 1 comment Download
M xfa/src/fwl/src/theme/checkboxtp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimWriter.cpp View 1 2 chunks +8 lines, -9 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 1 4 chunks +22 lines, -23 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 1 3 chunks +15 lines, -15 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 1 4 chunks +28 lines, -28 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_graphics.cpp View 1 10 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. Manual merges in: fpdfsdk/src/fpdfview.cpp fpdfsdk/src/fsdk_mgr.cpp
5 years ago (2015-12-10 23:01:18 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/1519693002/diff/20001/xfa/src/fdp/src/fde/fde_gedevice.cpp File xfa/src/fdp/src/fde/fde_gedevice.cpp (right): https://codereview.chromium.org/1519693002/diff/20001/xfa/src/fdp/src/fde/fde_gedevice.cpp#newcode184 xfa/src/fdp/src/fde/fde_gedevice.cpp:184: -fFontSize, (const CFX_Matrix*)pMatrix, No need for casts BTW. ...
5 years ago (2015-12-10 23:14:01 UTC) #2
Tom Sepez
5 years ago (2015-12-10 23:35:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
60d909e9d4444b2b8582275624ee97734d331a38 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698