Remove CFX_AffineMatrix/CPDF_Matrix

Remove CFX_AffineMatrix/CPDF_Matrix

These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/f32c969bce6743fca1e7ff796b54a1692d26d7f0

[Tom Sepez, 2015-12-10 20:54:52]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-12-10 20:54:53]

Lei, for review.  I spend a few seconds wondering about why I didn't get a
conflict betweem these types while doing unrelated work ...

[Tom Sepez, 2015-12-10 20:58:10]

Description was changed from

==========
Remove CFX_AffineMatrix/CPDF_Matrix

These are synonyms for CFX_Matrix.
Nothing but sed and manaul deletion of 2 #defines.
==========

to

==========
Remove CFX_AffineMatrix/CPDF_Matrix

These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h
==========

[Lei Zhang, 2015-12-10 22:34:02]

lgtm

https://codereview.chromium.org/1513363002/diff/1/core/include/fpdfapi/fpdf_m...
File core/include/fpdfapi/fpdf_module.h (right):

https://codereview.chromium.org/1513363002/diff/1/core/include/fpdfapi/fpdf_m...
core/include/fpdfapi/fpdf_module.h:15: class CFX_Matrix;
Alphabetical order

https://codereview.chromium.org/1513363002/diff/1/core/include/fpdfapi/fpdf_p...
File core/include/fpdfapi/fpdf_parser.h (right):

https://codereview.chromium.org/1513363002/diff/1/core/include/fpdfapi/fpdf_p...
core/include/fpdfapi/fpdf_parser.h:18: class CFX_Matrix;
nit: alphabetical order.

https://codereview.chromium.org/1513363002/diff/1/fpdfsdk/src/fpdf_flatten.cpp
File fpdfsdk/src/fpdf_flatten.cpp (right):

https://codereview.chromium.org/1513363002/diff/1/fpdfsdk/src/fpdf_flatten.cp...
fpdfsdk/src/fpdf_flatten.cpp:255: CFX_Matrix GetMatrix(CPDF_Rect rcAnnot,
CPDF_Rect rcStream, CFX_Matrix matrix) {
const ref?

[Tom Sepez, 2015-12-10 22:48:41]

https://codereview.chromium.org/1513363002/diff/1/core/include/fpdfapi/fpdf_m...
File core/include/fpdfapi/fpdf_module.h (right):

https://codereview.chromium.org/1513363002/diff/1/core/include/fpdfapi/fpdf_m...
core/include/fpdfapi/fpdf_module.h:15: class CFX_Matrix;
On 2015/12/10 22:34:02, Lei Zhang wrote:
> Alphabetical order

Done.

https://codereview.chromium.org/1513363002/diff/1/core/include/fpdfapi/fpdf_p...
File core/include/fpdfapi/fpdf_parser.h (right):

https://codereview.chromium.org/1513363002/diff/1/core/include/fpdfapi/fpdf_p...
core/include/fpdfapi/fpdf_parser.h:18: class CFX_Matrix;
On 2015/12/10 22:34:02, Lei Zhang wrote:
> nit: alphabetical order.

Done.

https://codereview.chromium.org/1513363002/diff/1/fpdfsdk/src/fpdf_flatten.cpp
File fpdfsdk/src/fpdf_flatten.cpp (right):

https://codereview.chromium.org/1513363002/diff/1/fpdfsdk/src/fpdf_flatten.cp...
fpdfsdk/src/fpdf_flatten.cpp:255: CFX_Matrix GetMatrix(CPDF_Rect rcAnnot,
CPDF_Rect rcStream, CFX_Matrix matrix) {
On 2015/12/10 22:34:02, Lei Zhang wrote:
> const ref?
Ok.  There's a big CL one can cobble up to pass CFX_Matrix by const ref
everywhere ...

https://codereview.chromium.org/1513363002/diff/1/fpdfsdk/src/fpdf_flatten.cp...
fpdfsdk/src/fpdf_flatten.cpp:276: CFX_Matrix matrix) {
here too.

[Tom Sepez, 2015-12-10 22:49:32]

Description was changed from

==========
Remove CFX_AffineMatrix/CPDF_Matrix

These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h
==========

to

==========
Remove CFX_AffineMatrix/CPDF_Matrix

These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/f32c969bce6743fca1e7ff796b54a1692d26...
==========

[Tom Sepez, 2015-12-10 22:49:34]

Committed patchset #2 (id:20001) manually as
f32c969bce6743fca1e7ff796b54a1692d26d7f0 (presubmit successful).