Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1519413002: Issue 25244. Disable invalid overrides. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -34 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 7 chunks +60 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 3 chunks +118 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-13 21:45:04 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-13 23:48:57 UTC) #2
scheglov
5 years ago (2015-12-13 23:50:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38a4193b5fb9bd6f2de73c099cc09a113d301664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698