Issue 25244. Disable invalid overrides.

pkg/analysis_server/test/analysis/notification_overrides_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.analysis.notification.overrides;
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
 import 'package:analysis_server/src/constants.dart';
@@ skipping 53 matching lines @@
   }
 
   /**
    * Asserts that there are no overridden members from interfaces.
    */
   void assertNoInterfaceMembers() {
     expect(override.interfaceMembers, isNull);
   }
 
   /**
+   * Validates that there is no [Override] at the offset of [search].
+   *
+   * If [length] is not specified explicitly, then length of an identifier
+   * from [search] is used.
+   */
+  void assertNoOverride(String search, [int length = -1]) {
+    int offset = findOffset(search);
+    if (length == -1) {
+      length = findIdentifierLength(search);
+    }
+    findOverride(offset, length, false);
+  }
+
+  /**
    * Asserts that there are no overridden member from the superclass.
    */
   void assertNoSuperMember() {
     expect(override.superclassMember, isNull);
   }
 
   /**
    * Finds an [Override] with the given [offset] and [length].
    *
    * If [exists] is `true`, then fails if such [Override] does not exist.
@@ skipping 46 matching lines @@
   m() {} // in B
 }
 ''');
     await waitForTasksFinished();
     await prepareOverrides();
     assertHasOverride('m() {} // in B');
     assertNoSuperMember();
     assertHasInterfaceMember('m() {} // in A');
   }
 
+  test_BAD_fieldByMethod() async {
+    addTestFile('''
+class A {
+  int fff; // in A
+}
+class B extends A {
+  fff() {} // in B
+}
+''');
+    await prepareOverrides();
+    assertNoOverride('fff() {} // in B');
+  }
+
+  test_BAD_getterByMethod() async {
+    addTestFile('''
+class A {
+  get fff => null;
+}
+class B extends A {
+  fff() {}
+}
+''');
+    await prepareOverrides();
+    assertNoOverride('fff() {}');
+  }
+
+  test_BAD_getterBySetter() async {
+    addTestFile('''
+class A {
+  get fff => null;
+}
+class B extends A {
+  set fff(x) {}
+}
+''');
+    await prepareOverrides();
+    assertNoOverride('fff(x) {}');
+  }
+
+  test_BAD_methodByField() async {
+    addTestFile('''
+class A {
+  fff() {} // in A
+}
+class B extends A {
+  int fff; // in B
+}
+''');
+    await prepareOverrides();
+    assertNoOverride('fff; // in B');
+  }
+
+  test_BAD_methodByGetter() async {
+    addTestFile('''
+class A {
+  fff() {}
+}
+class B extends A {
+  int get fff => null;
+}
+''');
+    await prepareOverrides();
+    assertNoOverride('fff => null');
+  }
+
+  test_BAD_methodBySetter() async {
+    addTestFile('''
+class A {
+  fff(x) {} // A
+}
+class B extends A {
+  set fff(x) {} // B
+}
+''');
+    await prepareOverrides();
+    assertNoOverride('fff(x) {} // B');
+  }
+
+  test_BAD_setterByGetter() async {
+    addTestFile('''
+class A {
+  set fff(x) {}
+}
+class B extends A {
+  get fff => null;
+}
+''');
+    await prepareOverrides();
+    assertNoOverride('fff => null;');
+  }
+
+  test_BAD_setterByMethod() async {
+    addTestFile('''
+class A {
+  set fff(x) {} // A
+}
+class B extends A {
+  fff(x) {} // B
+}
+''');
+    await prepareOverrides();
+    assertNoOverride('fff(x) {} // B');
+  }
+
   test_definedInInterface_ofInterface() async {
     addTestFile('''
 class A {
   m() {} // in A
 }
 class B implements A {}
 class C implements B {
   m() {} // in C
 }
 ''');
@@ skipping 161 matching lines @@
 class B extends A {
   get fff => 0; // in B
 }
 ''');
     await prepareOverrides();
     assertHasOverride('fff => 0; // in B');
     assertHasSuperElement('fff; // in A');
     assertNoInterfaceMembers();
   }
 
-  test_super_fieldByMethod() async {
-    addTestFile('''
-class A {
-  int fff; // in A
-}
-class B extends A {
-  fff() {} // in B
-}
-''');
-    await prepareOverrides();
-    assertHasOverride('fff() {} // in B');
-    assertHasSuperElement('fff; // in A');
-    assertNoInterfaceMembers();
-  }
-
   test_super_fieldBySetter() async {
     addTestFile('''
 class A {
   int fff; // in A
 }
 class B extends A {
   set fff(x) {} // in B
 }
 ''');
     await prepareOverrides();
@@ skipping 86 matching lines @@
 class B extends A {
   set fff(x) {} // in B
 }
 ''');
     await prepareOverrides();
     assertHasOverride('fff(x) {} // in B');
     assertHasSuperElement('fff(x) {} // in A');
     assertNoInterfaceMembers();
   }
 }