Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1519303002: MIPS: Fix for instanceof-proxies failure. (Closed)

Created:
5 years ago by paul.l...
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix for instanceof-proxies failure. Invalidate the instanceof cache in proxy-case of InstanceOfStub after the changes in https://codereview.chromium.org/1492243003. This didn't have a test case until https://codereview.chromium.org/1518773003 TEST=mjsunit/es6/instanceof-proxies.js BUG= Committed: https://crrev.com/dbe33c140eb28d2104e9bb15c618fc3a949246e9 Cr-Commit-Position: refs/heads/master@{#32821}

Patch Set 1 #

Total comments: 3

Patch Set 2 : store zero_reg, save an instruction. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/mips/code-stubs-mips.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
paul.l...
PTAL.
5 years ago (2015-12-12 02:26:49 UTC) #2
akos.palfi.imgtec
LGTM
5 years ago (2015-12-12 02:37:28 UTC) #3
dusan.milosavljevic
https://codereview.chromium.org/1519303002/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/1519303002/diff/1/src/mips/code-stubs-mips.cc#newcode1533 src/mips/code-stubs-mips.cc:1533: __ li(scratch, Operand(Smi::FromInt(0))); Can we use zero reg here?
5 years ago (2015-12-12 02:40:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519303002/1
5 years ago (2015-12-12 02:40:28 UTC) #7
dusan.milosavljevic
5 years ago (2015-12-12 02:42:58 UTC) #8
paul.l...
https://codereview.chromium.org/1519303002/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/1519303002/diff/1/src/mips/code-stubs-mips.cc#newcode1533 src/mips/code-stubs-mips.cc:1533: __ li(scratch, Operand(Smi::FromInt(0))); On 2015/12/12 02:40:25, dusan.milosavljevic wrote: > ...
5 years ago (2015-12-12 02:55:27 UTC) #9
paul.l...
https://codereview.chromium.org/1519303002/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/1519303002/diff/1/src/mips/code-stubs-mips.cc#newcode1533 src/mips/code-stubs-mips.cc:1533: __ li(scratch, Operand(Smi::FromInt(0))); On 2015/12/12 02:55:27, paul.l... wrote: > ...
5 years ago (2015-12-12 02:57:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519303002/20001
5 years ago (2015-12-12 03:12:46 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-12 03:29:34 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-12 03:30:26 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dbe33c140eb28d2104e9bb15c618fc3a949246e9
Cr-Commit-Position: refs/heads/master@{#32821}

Powered by Google App Engine
This is Rietveld 408576698