Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1492243003: [proxies] InstanceOfStub should bailout to %HasInPrototypeChain for proxies. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] InstanceOfStub should bailout to %HasInPrototypeChain for proxies. Whenever the InstanceOfStub finds a proxy (either passed as object or somewhere on the prototype chain), it should bailout to the %HasInPrototypeChain runtime function, which will do the right thing (soonish). R=yangguo@chromium.org BUG=v8:1543 LOG=n Committed: https://crrev.com/0e95683376c77332b6c5cf9195dd389f256e6ec4 Cr-Commit-Position: refs/heads/master@{#32549}

Patch Set 1 #

Patch Set 2 : Fix mips/mips64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -58 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +21 lines, -10 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +21 lines, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +23 lines, -11 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +21 lines, -10 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 1 chunk +21 lines, -10 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +19 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-03 07:16:02 UTC) #1
Benedikt Meurer
Hey Yang, Same fix for the InstanceOfStub. Please take a look. Thanks, Benedikt
5 years ago (2015-12-03 07:16:29 UTC) #2
Yang
On 2015/12/03 07:16:29, Benedikt Meurer wrote: > Hey Yang, > > Same fix for the ...
5 years ago (2015-12-03 08:29:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492243003/20001
5 years ago (2015-12-03 10:26:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 10:43:20 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 10:43:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e95683376c77332b6c5cf9195dd389f256e6ec4
Cr-Commit-Position: refs/heads/master@{#32549}

Powered by Google App Engine
This is Rietveld 408576698