Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1519073002: [proxies] Add missing condition to GetProperty consistency check. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Add missing condition to GetProperty consistency check. BUG=v8:1543 LOG=N R=cbruni@chromium.org,jkummerow@chromium.org Committed: https://crrev.com/4460b85a3e595a19a759876bd563f67bcb8cb586 Cr-Commit-Position: refs/heads/master@{#32832}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/objects.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-get.js View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
neis
Oops, forgot to send this one last week
5 years ago (2015-12-14 11:46:26 UTC) #1
Jakob Kummerow
lgtm
5 years ago (2015-12-14 11:52:26 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-14 11:56:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519073002/20001
5 years ago (2015-12-14 12:09:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/650) v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-14 12:25:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519073002/20001
5 years ago (2015-12-14 12:31:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 12:49:19 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-14 12:50:08 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4460b85a3e595a19a759876bd563f67bcb8cb586
Cr-Commit-Position: refs/heads/master@{#32832}

Powered by Google App Engine
This is Rietveld 408576698