src/objects.cc - Issue 1519073002: [proxies] Add missing condition to GetProperty consistency check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1519073002: [proxies] Add missing condition to GetProperty consistency check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 67ccd31014249127b5aede7c3cc6be3cdfc7af5e..b0962031545dfb922c7d3e060246a116daba7739 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -805,7 +805,8 @@ MaybeHandle<Object> JSProxy::GetProperty(Isolate* isolate,

inconsistent =

inconsistent ||

(PropertyDescriptor::IsAccessorDescriptor(&target_desc) &&

- !target_desc.configurable() && target_desc.get()->IsUndefined());

+ !target_desc.configurable() && target_desc.get()->IsUndefined() &&

+ !trap_result->IsUndefined());

if (inconsistent) {

THROW_NEW_ERROR(

isolate,

« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies-get.js » ('j') | no next file with comments »