Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: components/user_prefs/tracked/tracked_preference_histogram_names.h

Issue 1519043002: Putting histogram names of tracked prefs in tracked_preference_histogram_name file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Putting tracked namespace under user_prefs namespace. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_prefs/tracked/tracked_preference_histogram_names.h
diff --git a/components/user_prefs/tracked/tracked_preference_histogram_names.h b/components/user_prefs/tracked/tracked_preference_histogram_names.h
new file mode 100644
index 0000000000000000000000000000000000000000..05de0012bded2586782d1b60f358c421bb8f556f
--- /dev/null
+++ b/components/user_prefs/tracked/tracked_preference_histogram_names.h
@@ -0,0 +1,26 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_
Bernhard Bauer 2015/12/14 17:32:36 This header guard isn't correct. Shouldn't there h
Deepak 2015/12/15 04:39:36 Done.
+#define COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_
+
+namespace user_prefs {
+
gab 2015/12/14 19:29:27 no empty line between consecutive nested namespace
Deepak 2015/12/15 04:39:36 Done.
+namespace tracked {
+
+extern const char kTrackedPrefHistogramUnchanged[];
+extern const char kTrackedPrefHistogramCleared[];
+extern const char kTrackedPrefHistogramMigratedLegacyDeviceId[];
+extern const char kTrackedPrefHistogramChanged[];
+extern const char kTrackedPrefHistogramInitialized[];
+extern const char kTrackedPrefHistogramTrustedInitialized[];
+extern const char kTrackedPrefHistogramNullInitialized[];
+extern const char kTrackedPrefHistogramWantedReset[];
+extern const char kTrackedPrefHistogramReset[];
+extern const char kTrackedSplitPrefHistogramChanged[];
+}
Bernhard Bauer 2015/12/14 17:32:37 Empty line before this to match the opening namesp
Deepak 2015/12/15 04:39:36 Done.
+
+} // namespace tracked_pref_histogram_names
Bernhard Bauer 2015/12/14 17:32:37 namespace user_prefs
Deepak 2015/12/15 04:39:36 Done.
+
+#endif // COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

Powered by Google App Engine
This is Rietveld 408576698