components/user_prefs/tracked/tracked_preference_histogram_names.h - Issue 1519043002: Putting histogram names of tracked prefs in tracked_preference_histogram_name file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/user_prefs/tracked/tracked_preference_histogram_names.h

Issue 1519043002: Putting histogram names of tracked prefs in tracked_preference_histogram_name file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Putting tracked namespace under user_prefs namespace. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/user_prefs/tracked/tracked_preference_helper.cc ('K') | « components/user_prefs/tracked/tracked_preference_helper.cc ('k') | components/user_prefs/tracked/tracked_preference_histogram_names.cc » ('j') | components/user_prefs/tracked/tracked_preference_histogram_names.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_
	Bernhard Bauer 2015/12/14 17:32:36 This header guard isn't correct. Shouldn't there h This header guard isn't correct. Shouldn't there have been a presubmit check warning about this? If there wasn't, please check that your checkout is correctly set up. Deepak 2015/12/15 04:39:36 Done. Show quoted text On 2015/12/14 17:32:36, Bernhard Bauer wrote: > This header guard isn't correct. Shouldn't there have been a presubmit check > warning about this? If there wasn't, please check that your checkout is > correctly set up. Done.
	6 #define COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

	7

	8 namespace user_prefs {

	9
	gab 2015/12/14 19:29:27 no empty line between consecutive nested namespace no empty line between consecutive nested namespaces (same at bottom when closing and in .cc) Deepak 2015/12/15 04:39:36 Done. Show quoted text On 2015/12/14 19:29:27, gab wrote: > no empty line between consecutive nested namespaces (same at bottom when closing > and in .cc) Done.
	10 namespace tracked {

	11

	12 extern const char kTrackedPrefHistogramUnchanged[];

	13 extern const char kTrackedPrefHistogramCleared[];

	14 extern const char kTrackedPrefHistogramMigratedLegacyDeviceId[];

	15 extern const char kTrackedPrefHistogramChanged[];

	16 extern const char kTrackedPrefHistogramInitialized[];

	17 extern const char kTrackedPrefHistogramTrustedInitialized[];

	18 extern const char kTrackedPrefHistogramNullInitialized[];

	19 extern const char kTrackedPrefHistogramWantedReset[];

	20 extern const char kTrackedPrefHistogramReset[];

	21 extern const char kTrackedSplitPrefHistogramChanged[];

	22 }
	Bernhard Bauer 2015/12/14 17:32:37 Empty line before this to match the opening namesp Empty line before this to match the opening namespace declaration. Also, add a comment // namespace tracked. Deepak 2015/12/15 04:39:36 Done. Show quoted text On 2015/12/14 17:32:37, Bernhard Bauer wrote: > Empty line before this to match the opening namespace declaration. Also, add a > comment // namespace tracked. Done.
	23

	24 } // namespace tracked_pref_histogram_names
	Bernhard Bauer 2015/12/14 17:32:37 namespace user_prefs namespace user_prefs Deepak 2015/12/15 04:39:36 Done. Show quoted text On 2015/12/14 17:32:37, Bernhard Bauer wrote: > namespace user_prefs Done.
	25

	26 #endif // COMPONENTS_TRACKED_PREFERENCE_HISTOGRAM_NAMES_H_

OLD	NEW