Issue 151903003: MIPS: Remove CallICs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151903003: MIPS: Remove CallICs (Closed)

Created:
6 years, 10 months ago by palfia

Modified:
6 years, 10 months ago

Reviewers:
Paul Lind, danno, kisg, kilvadyb, Toon Verwaest, dusmil

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Remove CallICs Port r19001 (4b5aa649) BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=19009

Patch Set 2 : Optimized push instructions. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -842 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	1	3 chunks	+84 lines, -69 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View		6 chunks	+107 lines, -56 lines	0 comments	Download
M	src/mips/ic-mips.cc	View		4 chunks	+4 lines, -330 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+2 lines, -7 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View		4 chunks	+2 lines, -377 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

Sorry, I didn't pub the comments, here you go... https://codereview.chromium.org/151903003/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/151903003/diff/1/src/mips/code-stubs-mips.cc#newcode3327 src/mips/code-stubs-mips.cc:3327: ...

6 years, 10 months ago (2014-02-01 02:15:37 UTC) #4

palfia

6 years, 10 months ago (2014-02-01 02:23:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r19009 (presubmit successful).

Expand Messages | Collapse Messages

Issue 151903003: MIPS: Remove CallICs (Closed)

Description

Patch Set 1 #

Patch Set 2 : Optimized push instructions. #

Messages