Issue 1519013002: Remove the enable_basic_printing and enable_print_preview gn args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1519013002: Remove the enable_basic_printing and enable_print_preview gn args. (Closed)

Created:
5 years ago by viettrungluu

Modified:
5 years ago

Reviewers:
kulakowski1, kulakowski

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove the enable_basic_printing and enable_print_preview gn args. More usefully, this removes a couple of defines, which de-ices FNL gcc. Haha. R=kulakowski@google.com, kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/76c5853ec7bb6244619c298e77f562d31694f9b7

Created: 5 years ago

	Unified diffs	Side-by-side diffs	Stats (+1 line, -34 lines)
M	build/config/BUILD.gn	View	1 chunk	+0 lines, -13 lines	0 comments
M	build/config/features.gni	View	1 chunk	+0 lines, -7 lines	0 comments
M	build/secondary/tools/grit/grit_rule.gni	View	1 chunk	+0 lines, -13 lines	0 comments
M	skia/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments

Dependent Patchsets:

Total messages: 5 (2 generated)

viettrungluu

5 years ago (2015-12-11 17:02:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
76c5853ec7bb6244619c298e77f562d31694f9b7 (presubmit successful).