Issue 1514483008: Don't remove StackTrace::OutputToStream() for FNL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1514483008: Don't remove StackTrace::OutputToStream() for FNL. (Closed)

Created:
5 years ago by viettrungluu

Modified:
5 years ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@fix_fnl_1

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Don't remove StackTrace::OutputToStream() for FNL. Doing so is super-fragile (and is currently busted, at least for Debug builds). Instead, just neuter it. (Also remove some OS_WIN stuff.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/18a6ce7215ece72e4359600852bb0cf5fd87339f

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -36 lines)			Patch
M	base/debug/stack_trace.h	View	3 chunks	+1 line, -20 lines	0 comments	Download
M	base/debug/stack_trace.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/debug/stack_trace_posix.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	base/debug/stack_trace_unittest.cc	View	3 chunks	+1 line, -12 lines	0 comments	Download

Depends on Patchset:

Total messages: 4 (1 generated)

viettrungluu

5 years ago (2015-12-11 15:51:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18a6ce7215ece72e4359600852bb0cf5fd87339f (presubmit successful).