[Android WebView] Update microdump generation for sandboxed renderers

[Android WebView] Update microdump generation for sandboxed renderers

Now microdump handling has three modes depending on the process type:

"webview"    -- displays crash dialog, supports dump on demand;
"" (browser) -- displays crash dialog, doesn't support dump on demand;
"renderer"   -- doesn't display crash dialog, no dump on demand.

Dump on demand may be enabled later if we figure out how to do it
properly for sandboxed renderers.

Exported `InitMicrodumpCrashHandlerIfNecessary` as calling
`InitNonBrowserCrashReporterForAndroid` for that purpose is misleading,
and WebView doesn't need any of the functionality that it can enable.

BUG=568825
Committed: https://crrev.com/412d1a272f9f7b68803ca5932e96049ae86171be
Cr-Commit-Position: refs/heads/master@{#364766}

[mnaganov (inactive), 2015-12-10 21:51:55]

mnaganov@chromium.org changed reviewers:
+ torne@chromium.org

[mnaganov (inactive), 2015-12-10 23:43:45]

Description was changed from

==========
[Android WebView] Update microdump generation for sandboxed renderers

Now microdump handling has three modes depending on the process type:

"webview"    -- displays crash dialog, supports dump on demand;
"" (browser) -- displays crash dialog, doesn't support dump on demand;
"renderer"   -- doesn't display crash dialog, no dump on demand.

Dump on demand may be enabled later if we figure out how to do it
properly for sandboxed renderers.

Exported `InitMicrodumpCrashHandlerIfNecessary` as calling
`InitNonBrowserCrashReporterForAndroid` for that purpose is misleading,
and WebView doesn't need any of the functionality that it can enable.
==========

to

==========
[Android WebView] Update microdump generation for sandboxed renderers

Now microdump handling has three modes depending on the process type:

"webview"    -- displays crash dialog, supports dump on demand;
"" (browser) -- displays crash dialog, doesn't support dump on demand;
"renderer"   -- doesn't display crash dialog, no dump on demand.

Dump on demand may be enabled later if we figure out how to do it
properly for sandboxed renderers.

Exported `InitMicrodumpCrashHandlerIfNecessary` as calling
`InitNonBrowserCrashReporterForAndroid` for that purpose is misleading,
and WebView doesn't need any of the functionality that it can enable.

BUG=568825
==========

[Torne, 2015-12-11 15:41:42]

LGTM except for typo ;)

https://codereview.chromium.org/1518913002/diff/20001/components/crash/conten...
File components/crash/content/app/breakpad_linux.h (right):

https://codereview.chromium.org/1518913002/diff/20001/components/crash/conten...
components/crash/content/app/breakpad_linux.h:24: // Enables *micro*dump only.
Can be calleed from any process.
typo: calleed

[mnaganov (inactive), 2015-12-11 16:21:04]

https://codereview.chromium.org/1518913002/diff/20001/components/crash/conten...
File components/crash/content/app/breakpad_linux.h (right):

https://codereview.chromium.org/1518913002/diff/20001/components/crash/conten...
components/crash/content/app/breakpad_linux.h:24: // Enables *micro*dump only.
Can be calleed from any process.
On 2015/12/11 15:41:41, Torne wrote:
> typo: calleed

Done.

[mnaganov (inactive), 2015-12-11 16:21:33]

mnaganov@chromium.org changed reviewers:
+ rsesek@chromium.org

[mnaganov (inactive), 2015-12-11 16:21:34]

rsesek@: PTAL components/crash

[Robert Sesek, 2015-12-11 18:02:10]

lgtm

[mnaganov (inactive), 2015-12-11 18:11:13]

The CQ bit was checked by mnaganov@chromium.org

[mnaganov (inactive), 2015-12-11 18:11:13]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/1518913002/#ps40001
(title: "Fixed typo")

[commit-bot: I haz the power, 2015-12-11 18:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1518913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1518913002/40001

[commit-bot: I haz the power, 2015-12-11 19:12:56]

Description was changed from

==========
[Android WebView] Update microdump generation for sandboxed renderers

Now microdump handling has three modes depending on the process type:

"webview"    -- displays crash dialog, supports dump on demand;
"" (browser) -- displays crash dialog, doesn't support dump on demand;
"renderer"   -- doesn't display crash dialog, no dump on demand.

Dump on demand may be enabled later if we figure out how to do it
properly for sandboxed renderers.

Exported `InitMicrodumpCrashHandlerIfNecessary` as calling
`InitNonBrowserCrashReporterForAndroid` for that purpose is misleading,
and WebView doesn't need any of the functionality that it can enable.

BUG=568825
==========

to

==========
[Android WebView] Update microdump generation for sandboxed renderers

Now microdump handling has three modes depending on the process type:

"webview"    -- displays crash dialog, supports dump on demand;
"" (browser) -- displays crash dialog, doesn't support dump on demand;
"renderer"   -- doesn't display crash dialog, no dump on demand.

Dump on demand may be enabled later if we figure out how to do it
properly for sandboxed renderers.

Exported `InitMicrodumpCrashHandlerIfNecessary` as calling
`InitNonBrowserCrashReporterForAndroid` for that purpose is misleading,
and WebView doesn't need any of the functionality that it can enable.

BUG=568825
==========

[commit-bot: I haz the power, 2015-12-11 19:12:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-11 19:14:55]

Description was changed from

==========
[Android WebView] Update microdump generation for sandboxed renderers

Now microdump handling has three modes depending on the process type:

"webview"    -- displays crash dialog, supports dump on demand;
"" (browser) -- displays crash dialog, doesn't support dump on demand;
"renderer"   -- doesn't display crash dialog, no dump on demand.

Dump on demand may be enabled later if we figure out how to do it
properly for sandboxed renderers.

Exported `InitMicrodumpCrashHandlerIfNecessary` as calling
`InitNonBrowserCrashReporterForAndroid` for that purpose is misleading,
and WebView doesn't need any of the functionality that it can enable.

BUG=568825
==========

to

==========
[Android WebView] Update microdump generation for sandboxed renderers

Now microdump handling has three modes depending on the process type:

"webview"    -- displays crash dialog, supports dump on demand;
"" (browser) -- displays crash dialog, doesn't support dump on demand;
"renderer"   -- doesn't display crash dialog, no dump on demand.

Dump on demand may be enabled later if we figure out how to do it
properly for sandboxed renderers.

Exported `InitMicrodumpCrashHandlerIfNecessary` as calling
`InitNonBrowserCrashReporterForAndroid` for that purpose is misleading,
and WebView doesn't need any of the functionality that it can enable.

BUG=568825

Committed: https://crrev.com/412d1a272f9f7b68803ca5932e96049ae86171be
Cr-Commit-Position: refs/heads/master@{#364766}
==========

[commit-bot: I haz the power, 2015-12-11 19:14:56]

Patchset 3 (id:??) landed as
https://crrev.com/412d1a272f9f7b68803ca5932e96049ae86171be
Cr-Commit-Position: refs/heads/master@{#364766}