Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: components/crash/content/app/breakpad_linux.cc

Issue 1518913002: [Android WebView] Update microdump generation for sandboxed renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typo Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/content/app/breakpad_linux.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/breakpad_linux.cc
diff --git a/components/crash/content/app/breakpad_linux.cc b/components/crash/content/app/breakpad_linux.cc
index 7a5c5dde37ebf93ab7b57fc69bb26389d6d478b4..62888ad9ff5fa9f6d88feb8e640bb66d886070a3 100644
--- a/components/crash/content/app/breakpad_linux.cc
+++ b/components/crash/content/app/breakpad_linux.cc
@@ -739,31 +739,6 @@ bool MicrodumpCrashDone(const MinidumpDescriptor& minidump,
return FinalizeCrashDoneAndroid(is_browser_process);
}
-// The microdump handler does NOT upload anything. It just dumps out on the
-// system console (logcat) a restricted and serialized variant of a minidump.
-// See crbug.com/410294 for more details.
-void InitMicrodumpCrashHandlerIfNecessary(const std::string& process_type) {
- if (!GetCrashReporterClient()->ShouldEnableBreakpadMicrodumps())
- return;
-
- VLOG(1) << "Enabling microdumps crash handler (process_type:"
- << process_type << ")";
-
- // The exception handler runs in a compromised context and cannot use c_str()
- // as that would require the heap. Therefore, we have to guarantee that the
- // build fingerprint and product info pointers are always valid.
- const char* product_name = nullptr;
- const char* product_version = nullptr;
- GetCrashReporterClient()->GetProductNameAndVersion(&product_name,
- &product_version);
-
- const char* android_build_fp =
- base::android::BuildInfo::GetInstance()->android_build_fp();
-
- g_microdump_info.Get().Initialize(process_type, product_name, product_version,
- android_build_fp);
-}
-
bool CrashDoneInProcessNoUpload(
const google_breakpad::MinidumpDescriptor& descriptor,
void* context,
@@ -1858,6 +1833,31 @@ void InitNonBrowserCrashReporterForAndroid(const std::string& process_type) {
}
}
+// The microdump handler does NOT upload anything. It just dumps out on the
+// system console (logcat) a restricted and serialized variant of a minidump.
+// See crbug.com/410294 for more details.
+void InitMicrodumpCrashHandlerIfNecessary(const std::string& process_type) {
+ if (!GetCrashReporterClient()->ShouldEnableBreakpadMicrodumps())
+ return;
+
+ VLOG(1) << "Enabling microdumps crash handler (process_type:"
+ << process_type << ")";
+
+ // The exception handler runs in a compromised context and cannot use c_str()
+ // as that would require the heap. Therefore, we have to guarantee that the
+ // build fingerprint and product info pointers are always valid.
+ const char* product_name = nullptr;
+ const char* product_version = nullptr;
+ GetCrashReporterClient()->GetProductNameAndVersion(&product_name,
+ &product_version);
+
+ const char* android_build_fp =
+ base::android::BuildInfo::GetInstance()->android_build_fp();
+
+ g_microdump_info.Get().Initialize(process_type, product_name, product_version,
+ android_build_fp);
+}
+
void AddGpuFingerprintToMicrodumpCrashHandler(
const std::string& gpu_fingerprint) {
g_microdump_info.Get().SetGpuFingerprint(gpu_fingerprint);
« no previous file with comments | « components/crash/content/app/breakpad_linux.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698